feat: alert safari users of 7 day data delete policy of safari

Author: abose

src/extensions/default/Phoenix/main.js

@@ -31,7 +31,7 @@ define(function (require, exports, module) {
         AppInit      = brackets.getModule("utils/AppInit"),
         Strings      = brackets.getModule("strings"),
         Dialogs      = brackets.getModule("widgets/Dialogs"),
-        Mustache     = brackets.getModule("thirdparty/mustache/mustache"),
+        NotificationUI  = brackets.getModule("widgets/NotificationUI"),
         DefaultDialogs = brackets.getModule("widgets/DefaultDialogs");
 
     const PERSIST_STORAGE_DIALOG_DELAY_SECS = 60000;
@@ -64,21 +64,28 @@ define(function (require, exports, module) {
             );
             return;
         }
+        Dialogs.showModalDialog(
+            DefaultDialogs.DIALOG_ID_ERROR,
+            Strings.UNSUPPORTED_BROWSER_TITLE,
+            Strings.UNSUPPORTED_BROWSER_MESSAGE
+        );
         if (!("serviceWorker" in navigator)) {
             // service worker is required for phcode to work
-            Dialogs.showModalDialog(
-                DefaultDialogs.DIALOG_ID_ERROR,
-                Strings.UNSUPPORTED_BROWSER_TITLE,
-                Strings.UNSUPPORTED_BROWSER_MESSAGE
-            );
-            throw new Error("Service worker is not supported by the browser.");
+            throw new Error("Service worker is not supported by the browser. Phcode cannot continue.");
         }
     }
 
     function _detectUnSupportedBrowser() {
         if(!Phoenix.isSupportedBrowser){
             _showUnSupportedBrowserDialogue();
         }
+        if(Phoenix.browser.desktop.isSafari || Phoenix.browser.mobile.isIos) {
+            NotificationUI.createToastFromTemplate( Strings.ATTENTION_SAFARI_USERS,
+                Strings.ATTENTION_SAFARI_USERS_MESSAGE, {
+                    dismissOnClick: false,
+                    toastStyle: NotificationUI.NOTIFICATION_STYLES_CSS_CLASS.DANGER
+                });
+        }
     }
 
     async function _persistBrowserStorage() {

src/index.html

@@ -120,9 +120,7 @@
                 firstBoot: false, // will be set below
                 startTime: Date.now()
             };
-            Phoenix.isSupportedBrowser = Phoenix.browser.isDeskTop &&
-                (Phoenix.browser.desktop.isChrome || Phoenix.browser.desktop.isEdgeChromium
-                    || Phoenix.browser.desktop.isOperaChromium);
+            Phoenix.isSupportedBrowser = Phoenix.browser.isDeskTop && ("serviceWorker" in navigator);
             window.testEnvironment = window.Phoenix.isTestWindow;
         }());
     </script>

src/nls/root/strings.js

@@ -962,6 +962,8 @@ define({
     "UNSUPPORTED_BROWSER_MOBILE": "Mobile and Tablet browsers are currently not fully supported. You may close this dialogue, but some features in Phoenix will not work in this browser. <br/><br/>We are working on developing native apps for iOS and Android. <a href=\"https://github.com/phcode-dev/phoenix/discussions/1046\" target=\"_blank\">Join the discussion here!</a>",
     "UNSUPPORTED_BROWSER_OPEN_FOLDER_TITLE": "Local Folder Access Unsupported by Browser",
     "UNSUPPORTED_BROWSER_OPEN_FOLDER": "Sorry, it looks like your current browser doesn't support opening local folders. For this feature, we recommend using Chrome, Edge, or Opera. <br/><br/>Alternatively, we're working on developing native apps for Windows, Mac, Linux, iOS, and Android to provide full support. <a href=\"https://github.com/phcode-dev/phoenix/discussions/1047\" target=\"_blank\">Stay tuned for updates!</a>",
+    "ATTENTION_SAFARI_USERS": "Attention Safari Users",
+    "ATTENTION_SAFARI_USERS_MESSAGE": "<span>Safari automatically deletes website data if a site is not revisited within 7 days. {APP_NAME} relies on browser storage to save your projects, which may be removed due to this policy. <br/> <br/><strong>To prevent data loss</strong>, please <strong>download</strong> your projects before closing the tab or stay tuned for our <strong>upcoming Web and native Mac/iOS apps</strong>.</span>",
     "CANNOT_PUBLISH_LARGE_PROJECT": "Cannot Publish Large Project",
     "CANNOT_PUBLISH_LARGE_PROJECT_MESSAGE": "Phoenix is still in experimental alpha. We have not yet enabled sync of projects with greater than 500 files.",
     "SHARE_WEBSITE": "Publish and Share Website?",

src/styles/brackets.less

@@ -2683,7 +2683,7 @@ label input {
     box-shadow: 0 0 20px rgba(0, 0, 0, 0.24);
     padding: 9px 12px 9px 12px;
     font-family: "SourceSansPro", serif;
-    color: black;
+    color: black; // text color
     line-height: 1.5;
     margin-top: 7px;
 
@@ -2692,6 +2692,10 @@ label input {
     transform: translateY(-50px);
 }
 
+.notification-dialog-content strong {
+    color: black; // text color
+}
+
 .notification-popup-container.style-danger {
     background: var(--bc-toast-danger-bg-color);
 }
@@ -2740,10 +2744,6 @@ label input {
     font-weight: bold;
 }
 
-.notification-dialog-content strong {
-    color: white;
-}
-
 .notification-dialog-content a {
     color: #00ccff;
 }

test/SpecRunner.html

@@ -108,9 +108,7 @@
         firstBoot: false, // will be set below
         startTime: Date.now()
       };
-      Phoenix.isSupportedBrowser = Phoenix.browser.isDeskTop &&
-              (Phoenix.browser.desktop.isChrome || Phoenix.browser.desktop.isEdgeChromium
-                      || Phoenix.browser.desktop.isOperaChromium);
+      Phoenix.isSupportedBrowser = Phoenix.browser.isDeskTop;
       window.testEnvironment = window.Phoenix.isTestWindow;
     }());
   </script>