Skip to content

Commit d40e75c

Browse files
committed
fix: using up arrow on a dialog input field opened from a popup also navigated the popup
1 parent 43c2a0a commit d40e75c

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/widgets/PopUpManager.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,9 @@ define(function (require, exports, module) {
8585
<span class="searchTextSpan"></span></a>
8686
</li>`);
8787
}
88+
$popUp.off("keydown", _processSelectionEvent);
89+
$popUp.on("keydown", _processSelectionEvent);
90+
$popUp.focus();
8891
}
8992

9093
/**
@@ -114,6 +117,7 @@ define(function (require, exports, module) {
114117
if(handlerIndex >= 0){
115118
currentEventPopups.splice(handlerIndex, 1);
116119
searchStr = "";
120+
$popUp.off("keydown", _processSelectionEvent);
117121
}
118122
// check index after removeHandler is done processing to protect
119123
// against recursive calls
@@ -299,11 +303,6 @@ define(function (require, exports, module) {
299303
}
300304

301305
function _keydownCaptureListener(keyEvent) {
302-
if(currentEventPopups.length) {
303-
if(_processSelectionEvent(keyEvent)){
304-
return true;
305-
}
306-
}
307306
// Escape key or Alt key (Windows-only)
308307
if (keyEvent.keyCode !== KeyEvent.DOM_VK_ESCAPE &&
309308
!(keyEvent.keyCode === KeyEvent.DOM_VK_ALT && brackets.platform === "win")) {

0 commit comments

Comments
 (0)