fix: first boot flag on phstore migration from legacy

Author: abose

src/preferences/StateManager.js

@@ -247,12 +247,7 @@ define(function (require, exports, module) {
      * @private
      */
     function _migrateLegacyStateFile() {
-        if(Phoenix.firstBoot || Phoenix.isTestWindow){
-            // nothing to migrate, fresh install
-            setVal(LEGACY_STATE_MANAGER_MIGRATED, true);
-            return new $.Deferred().resolve().promise();
-        }
-        if(getVal(LEGACY_STATE_MANAGER_MIGRATED)){
+        if(Phoenix.isTestWindow || getVal(LEGACY_STATE_MANAGER_MIGRATED)){
             return new $.Deferred().resolve().promise();
         }
         const _migrated = new $.Deferred();

src/storage.js

@@ -236,6 +236,12 @@ import {set, entries, createStore} from './thirdparty/idb-keyval.js';
                 window.Phoenix.firstBoot = true;
                 setItem(FIRST_BOOT_TIME, Date.now());
             }
+            // legacy first boot. can be removed after sep 2024
+            // this was the original thing we used before we migrated to phStore.
+            let legacyKey = "healthData.firstUseDay";
+            if(localStorage.getItem(legacyKey)){
+                window.Phoenix.firstBoot = false;
+            }
         } catch (e) {
             console.error(e);
         }