chore: reveiwed uncaught exception handlers in git

Author: abose

src/extensions/default/Git/src/dialogs/Pull.js

@@ -1,16 +1,16 @@
 define(function (require, exports) {
 
     // Brackets modules
-    var Dialogs = brackets.getModule("widgets/Dialogs"),
+    const Dialogs = brackets.getModule("widgets/Dialogs"),
         Mustache = brackets.getModule("thirdparty/mustache/mustache");
 
     // Local modules
-    var Preferences     = require("src/Preferences"),
+    const Preferences     = require("src/Preferences"),
         RemoteCommon    = require("src/dialogs/RemoteCommon"),
         Strings         = brackets.getModule("strings");
 
     // Templates
-    var template            = require("text!src/dialogs/templates/pull-dialog.html"),
+    const template            = require("text!src/dialogs/templates/pull-dialog.html"),
         remotesTemplate     = require("text!src/dialogs/templates/remotes-template.html");
 
     // Implementation
@@ -54,6 +54,7 @@ define(function (require, exports) {
     function show(pullConfig) {
         return new Promise((resolve, reject) => {
             pullConfig.pull = true;
+            // collectInfo never rejects
             RemoteCommon.collectInfo(pullConfig).then(()=>{
                 _show(pullConfig, resolve, reject);
             });

src/extensions/default/Git/src/dialogs/Push.js

@@ -52,6 +52,7 @@ define(function (require, exports) {
     function show(pushConfig) {
         return new Promise((resolve, reject) => {
             pushConfig.push = true;
+            // collectInfo never rejects
             RemoteCommon.collectInfo(pushConfig).then(()=>{
                 _show(pushConfig, resolve, reject);
             });

src/extensions/default/Git/src/dialogs/RemoteCommon.js

@@ -28,6 +28,7 @@ define(function (require, exports) {
         });
     }
 
+    // this should never reject for now, just show error message and bail out
     exports.collectInfo = function (config) {
         return Git.getCurrentUpstreamBranch().then(function (upstreamBranch) {
             config.currentTrackingBranch = upstreamBranch;