Skip to content

Commit e31a3c5

Browse files
committed
refactor: move user facing strings of ruler lines to measurements
1 parent 80cde74 commit e31a3c5

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/LiveDevelopment/LivePreviewConstants.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,5 @@ define(function main(require, exports, module) {
4040
exports.HIGHLIGHT_HOVER = "hover";
4141
exports.HIGHLIGHT_CLICK = "click";
4242

43-
exports.PREFERENCE_SHOW_RULER_LINES = "livePreviewShowRulerLines";
43+
exports.PREFERENCE_SHOW_RULER_LINES = "livePreviewShowMeasurements";
4444
});

src/extensionsIntegrated/phoenix-pro/LivePreviewEdit.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ define(function (require, exports, module) {
1212
const HTMLInstrumentation = require("LiveDevelopment/MultiBrowserImpl/language/HTMLInstrumentation");
1313
const LiveDevMultiBrowser = require("LiveDevelopment/LiveDevMultiBrowser");
1414
const LiveDevelopment = require("LiveDevelopment/main");
15+
const Constants = require("LiveDevelopment/LivePreviewConstants");
1516
const CodeMirror = require("thirdparty/CodeMirror/lib/codemirror");
1617
const ProjectManager = require("project/ProjectManager");
1718
const PreferencesManager = require("preferences/PreferencesManager");
@@ -1825,7 +1826,7 @@ define(function (require, exports, module) {
18251826

18261827
// handle ruler lines toggle message
18271828
if (message.type === "toggleRulerLines") {
1828-
PreferencesManager.set("livePreviewShowRulerLines", message.enabled);
1829+
PreferencesManager.set(Constants.PREFERENCE_SHOW_RULER_LINES, message.enabled);
18291830
return;
18301831
}
18311832

src/nls/root/strings.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ define({
184184
"LIVE_DEV_SETTINGS_ELEMENT_HIGHLIGHT_HOVER": "hover",
185185
"LIVE_DEV_SETTINGS_ELEMENT_HIGHLIGHT_CLICK": "click",
186186
"LIVE_DEV_SETTINGS_ELEMENT_HIGHLIGHT_PREFERENCE": "Show live preview element highlights on 'hover' or 'click'. Defaults to 'hover'",
187-
"LIVE_DEV_SETTINGS_SHOW_RULER_LINES_PREFERENCE": "Show ruler lines when elements are selected in live preview. Defaults to 'false'",
187+
"LIVE_DEV_SETTINGS_SHOW_RULER_LINES_PREFERENCE": "Show measurements when elements are selected in live preview. Defaults to 'false'",
188188
"LIVE_DEV_MORE_OPTIONS_SELECT_PARENT": "Select Parent",
189189
"LIVE_DEV_MORE_OPTIONS_EDIT_TEXT": "Edit Text",
190190
"LIVE_DEV_MORE_OPTIONS_EDIT_HYPERLINK": "Edit Hyperlink",
@@ -227,7 +227,7 @@ define({
227227
"LIVE_PREVIEW_MODE_HIGHLIGHT": "Highlight Mode",
228228
"LIVE_PREVIEW_MODE_EDIT": "Edit Mode",
229229
"LIVE_PREVIEW_EDIT_HIGHLIGHT_ON": "Edit Highlights on Hover",
230-
"LIVE_PREVIEW_SHOW_RULER_LINES": "Show Ruler Lines",
230+
"LIVE_PREVIEW_SHOW_RULER_LINES": "Show Measurements",
231231
"LIVE_PREVIEW_MODE_PREFERENCE": "'{0}' shows only the webpage, '{1}' connects the webpage to your code - click on elements to jump to their code and vice versa, '{2}' provides highlighting along with advanced element manipulation",
232232
"LIVE_PREVIEW_CONFIGURE_MODES": "Configure Live Preview Modes",
233233

0 commit comments

Comments
 (0)