fix: github actions windows desktop tests fails after rust update, locked rust to 1.85.1

Author: abose

.github/workflows/desktop-linux-prod-test-pull.yml

@@ -20,6 +20,8 @@ jobs:
           node-version: 20
       - name: install Rust stable
         uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: 1.85.1
 
       - name: install dependencies (ubuntu only)
         run: |

.github/workflows/desktop-linux-test-pull.yml

@@ -19,6 +19,8 @@ jobs:
           node-version: 20
       - name: install Rust stable
         uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: 1.85.1
 
       - name: install dependencies (ubuntu only)
         run: |

.github/workflows/desktop-mac-m1-test-pull.yml

@@ -19,6 +19,8 @@ jobs:
           node-version: 20
       - name: install Rust stable
         uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: 1.85.1
 
       - name: build phoenix dist-test
         run: |

.github/workflows/desktop-mac-test-pull.yml

@@ -19,6 +19,8 @@ jobs:
           node-version: 20
       - name: install Rust stable
         uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: 1.85.1
 
       - name: build phoenix dist-test
         run: |

.github/workflows/desktop-windows-test-pull.yml

@@ -19,6 +19,8 @@ jobs:
           node-version: 20
       - name: install Rust stable
         uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: 1.85.1
 
       - name: build phoenix dist-test
         run: |

src/extensions/default/Git/src/ErrorHandler.js

@@ -46,7 +46,6 @@ define(function (require, exports) {
     exports.showError = function (err, title, options = {}) {
         const dontStripError = options.dontStripError;
         const errorMetric = options.errorMetric;
-        Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'dialogErr', errorMetric || "Show");
         if (err.__shown) { return err; }
 
         exports.logError(err);
@@ -71,13 +70,15 @@ define(function (require, exports) {
         errorBody = window.debugMode ? `${errorBody}\n${errorStack}` : errorBody;
 
         if(options.useNotification){
+            Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'notifyErr', errorMetric || "Show");
             NotificationUI.createToastFromTemplate(title,
                 `<textarea readonly style="width: 200px; height: 200px; cursor: text; resize: none;">${errorBody}</textarea>`, {
                     toastStyle: NotificationUI.NOTIFICATION_STYLES_CSS_CLASS.ERROR,
                     dismissOnClick: false,
                     instantOpen: true
                 });
         } else {
+            Metrics.countEvent(Metrics.EVENT_TYPE.GIT, 'dialogErr', errorMetric || "Show");
             const compiledTemplate = Mustache.render(errorDialogTemplate, {
                 title: title,
                 body: errorBody,