Skip to content

Commit ecbb517

Browse files
committed
chore: wiggly weavy underlines for error/warn/spell/info ui improve
1 parent 866a4e7 commit ecbb517

File tree

6 files changed

+24
-26
lines changed

6 files changed

+24
-26
lines changed

src/styles/brackets.less

Lines changed: 9 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -160,42 +160,22 @@ html, body {
160160
// selectors like .warning or .info. Even if error, warning, and info are used on the same div in any order,
161161
// the style for .error.error will take precedence due to its higher specificity.
162162
.editor-text-fragment-error.editor-text-fragment-error.editor-text-fragment-error.editor-text-fragment-error{
163-
text-decoration-style: wavy;
164-
text-decoration-line: underline;
165-
text-decoration-skip-ink: none;
166-
text-decoration-thickness: 1px;
167-
text-underline-offset: 1px;
168-
text-decoration-color: @error-underline-text;
163+
background: url('images/wavy-error.svg') repeat-x bottom left;
169164
}
170165

171166
.editor-text-fragment-warn.editor-text-fragment-warn.editor-text-fragment-warn {
172-
text-decoration-style: wavy;
173-
text-decoration-line: underline;
174-
text-decoration-skip-ink: none;
175-
text-decoration-thickness: 1px;
176-
text-underline-offset: 1px;
177-
text-decoration-color: @warn-underline-text;
167+
background: url('images/wavy-warn.svg') repeat-x bottom left;
178168
.dark &{
179-
text-decoration-color: @dark-warn-underline-text;
169+
background: url('images/wavy-warn-dark.svg') repeat-x bottom left;
180170
}
181171
}
182172

183173
.editor-text-fragment-spell-error.editor-text-fragment-spell-error {
184-
text-decoration-style: wavy;
185-
text-decoration-line: underline;
186-
text-decoration-skip-ink: none;
187-
text-decoration-thickness: 1px;
188-
text-underline-offset: 1px;
189-
text-decoration-color: @spell-underline-text;
174+
background: url('images/wavy-spell-error.svg') repeat-x bottom left;
190175
}
191176

192177
.editor-text-fragment-info {
193-
text-decoration-style: wavy;
194-
text-decoration-line: underline;
195-
text-decoration-skip-ink: none;
196-
text-decoration-thickness: 1px;
197-
text-underline-offset: 1px;
198-
text-decoration-color: @info-underline-text;
178+
background: url('images/wavy-info.svg') repeat-x bottom left;
199179
}
200180

201181
.hidden-element{
@@ -2002,7 +1982,10 @@ a, img {
20021982
}
20031983

20041984
.quick-view-highlight {
2005-
background-color: rgba(200, 200, 150, 0.4);
1985+
background-color: rgba(200, 200, 150, 0.4) !important;
1986+
.dark &{
1987+
background-color: rgba(150, 150, 50, 0.3) !important;
1988+
}
20061989
}
20071990

20081991
// selection view

src/styles/images/wavy-error.svg

Lines changed: 3 additions & 0 deletions
Loading

src/styles/images/wavy-info.svg

Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading
Lines changed: 3 additions & 0 deletions
Loading

src/styles/images/wavy-warn.svg

Lines changed: 3 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)