chore: make LivePreviewEdit.js movable to extension

Author: abose

gulpfile.js/index.js

@@ -789,7 +789,7 @@ function _renameExtensionConcatAsExtensionJSInDist(extensionName) {
 }
 
 const minifyableExtensions = ["CloseOthers", "CodeFolding", "DebugCommands", "Git",
-    "HealthData", "JavaScriptCodeHints", "JavaScriptRefactoring", "QuickView"];
+    "HealthData", "JavaScriptCodeHints", "JavaScriptRefactoring", "QuickView", "phoenix-pro"];
 // extensions that nned not be minified either coz they are single file extensions or some other reason.
 const nonMinifyExtensions = ["CSSAtRuleCodeHints", "CSSCodeHints",
     "CSSPseudoSelectorHints", "DarkTheme", "HandlebarsSupport", "HTMLCodeHints", "HtmlEntityCodeHints",

src/LiveDevelopment/LivePreviewEdit.js

@@ -41,7 +41,8 @@ define(function (require, exports, module) {
     const ProDialogs = require("services/pro-dialogs");
     const Mustache = require("thirdparty/mustache/mustache");
     const Strings = require("strings");
-    const ImageFolderDialogTemplate = require("text!htmlContent/image-folder-dialog.html");
+    const ImageFolderDialogTemplate = require("text!htmlContent/image-folder-dialog.html"); // todo move to extension
+    const LiveDevProtocol = require("LiveDevelopment/MultiBrowserImpl/protocol/LiveDevProtocol");
 
     // state manager key, to save the download location of the image
     const IMAGE_DOWNLOAD_FOLDER_KEY = "imageGallery.downloadFolder";
@@ -1820,5 +1821,9 @@ define(function (require, exports, module) {
         }
     }
 
-    exports.handleLivePreviewEditOperation = handleLivePreviewEditOperation;
+    LiveDevProtocol.setLivePreviewMessageHandler((msg)=>{
+        if (msg.livePreviewEditEnabled) {
+            handleLivePreviewEditOperation(msg);
+        }
+    });
 });

src/LiveDevelopment/MultiBrowserImpl/protocol/LiveDevProtocol.js

@@ -52,8 +52,7 @@ define(function (require, exports, module) {
         HTMLInstrumentation   = require("LiveDevelopment/MultiBrowserImpl/language/HTMLInstrumentation"),
         StringUtils = require("utils/StringUtils"),
         FileViewController    = require("project/FileViewController"),
-        MainViewManager     = require("view/MainViewManager"),
-        LivePreviewEdit     = require("LiveDevelopment/LivePreviewEdit");
+        MainViewManager     = require("view/MainViewManager");
 
     const LIVE_DEV_REMOTE_SCRIPTS_FILE_NAME = `phoenix_live_preview_scripts_instrumented_${StringUtils.randomString(8)}.js`;
     const LIVE_DEV_REMOTE_WORKER_SCRIPTS_FILE_NAME = `pageLoaderWorker_${StringUtils.randomString(8)}.js`;
@@ -203,6 +202,11 @@ define(function (require, exports, module) {
         // for a fraction of a second. so a size of 1000 should be more than enough.
     });
 
+    let _livePreviewMessageHandler;
+    function setLivePreviewMessageHandler(handler) {
+        _livePreviewMessageHandler = handler;
+    }
+
     /**
      * @private
      * Handles a message received from the remote protocol handler via the transport.
@@ -227,8 +231,8 @@ define(function (require, exports, module) {
         } else if (messageID) {
             processedMessageIDs.set(messageID, true);
         }
-        if (msg.livePreviewEditEnabled) {
-            LivePreviewEdit.handleLivePreviewEditOperation(msg);
+        if(_livePreviewMessageHandler) {
+            _livePreviewMessageHandler(msg);
         }
 
         if (msg.id) {
@@ -498,6 +502,7 @@ define(function (require, exports, module) {
     exports.getConnectionIds = getConnectionIds;
     exports.closeAllConnections = closeAllConnections;
     exports.addRemoteFunctionScript = addRemoteFunctionScript;
+    exports.setLivePreviewMessageHandler = setLivePreviewMessageHandler;
     exports.LIVE_DEV_REMOTE_SCRIPTS_FILE_NAME = LIVE_DEV_REMOTE_SCRIPTS_FILE_NAME;
     exports.LIVE_DEV_REMOTE_WORKER_SCRIPTS_FILE_NAME = LIVE_DEV_REMOTE_WORKER_SCRIPTS_FILE_NAME;
     exports.EVENT_LIVE_PREVIEW_CLICKED = EVENT_LIVE_PREVIEW_CLICKED;

src/LiveDevelopment/RemoteHelper.js

@@ -34,7 +34,7 @@
  */
 
 define(function (require, exports, module) {
-    const Strings = require("strings");
+    const Strings = require("strings"); // todo move to code construction logic
 
     // list of all the strings that are used in the remoteFunctions file
     const remoteStrings = {