fix: pro logo doesnt go away on logout on top left navbar

Author: abose

src/index.html

@@ -350,7 +350,7 @@
                 baseURL: _getBaseURL(),
                 isTestWindow: _isTestWindow(),
                 firstBoot: false, // will be set below
-                pro: {},
+                pro: {}, // this is only for display purposes and should not be used to gate features. use kernal mode for that
                 startTime: Date.now(),
                 TRUSTED_ORIGINS: {
                     // if modifying this list, make sure to update in https://github.com/phcode-dev/phcode.live/blob/main/docs/trustedOrigins.js

src/services/profile-menu.js

@@ -190,12 +190,13 @@ define(function (require, exports, module) {
     function _updateBranding(entitlements) {
         const $brandingLink = $("#phcode-io-main-nav");
         if (!entitlements) {
+            // Phoenix.pro is only for display purposes and should not be used to gate features.
+            // Use kernal mode apis for trusted check of pro features.
             Phoenix.pro.plan = {
                 paidSubscriber: false,
                 name: "Community Edition",
                 isInTrial: false
             };
-            return;
         }
 
         if (entitlements && entitlements.plan){