feat: enable git extension in desktop app by default

Author: abose

src/extensions/default/DefaultExtensions.json

@@ -25,6 +25,9 @@
     "UrlCodeHints",
     "HealthData"
   ],
+  "desktopOnly": [
+    "Git"
+  ],
  "warnExtensionStoreExtensions": {
    "description": "list extension ids here that you want to show this warning in extension store: 'You may not need this extension. Phoenix comes built in with this feature.'",
    "note": "This is only to for legacy extensions that havent been updated for a long time, remove flag unconditionally if instructed by the extension author, but inform of the issues in extension.",

src/utils/ExtensionLoader.js

@@ -54,8 +54,22 @@ define(function (require, exports, module) {
         UrlParams      = require("utils/UrlParams").UrlParams,
         NodeUtils = require("utils/NodeUtils"),
         PathUtils      = require("thirdparty/path-utils/path-utils"),
-        DefaultExtensionsList = JSON.parse(require("text!extensions/default/DefaultExtensions.json"))
-            .defaultExtensionsList;
+        DefaultExtensions = JSON.parse(require("text!extensions/default/DefaultExtensions.json"));
+
+    const desktopOnlyExtensions = DefaultExtensions.desktopOnly;
+    const DefaultExtensionsList = Phoenix.isNativeApp ?
+        [...DefaultExtensions.defaultExtensionsList, ...desktopOnlyExtensions]:
+        DefaultExtensions.defaultExtensionsList;
+
+    if(Phoenix.isTestWindow) {
+        // we dont load the heavy weight git extension by default for tests as huge number
+        // of tests written before git integration and too hard to fix those failing tests for now.
+        // we will just have new tests from git specific workflows.
+        const index = DefaultExtensionsList.indexOf("Git");
+        if(index !== -1) {
+            DefaultExtensionsList.splice(index, 1);
+        }
+    }
 
     const customExtensionLoadPaths = {};