fix: empty snippets were getting added when save button was clicked with no values

Author: devvaannsh

src/extensionsIntegrated/CustomSnippets/src/driver.js

@@ -13,6 +13,14 @@ define(function (require, exports, module) {
      */
     function handleSaveBtnClick() {
         const snippetData = Helper.getSnippetData();
+
+        if (!snippetData.abbreviation || !snippetData.abbreviation.trim()) {
+            return;
+        }
+        if (!snippetData.templateText || !snippetData.templateText.trim()) {
+            return;
+        }
+
         if (shouldAddSnippetToList(snippetData)) {
             Global.SnippetHintsList.push(snippetData);
             Helper.clearAllInputFields();
@@ -36,6 +44,13 @@ define(function (require, exports, module) {
         const originalSnippet = $editView.data("originalSnippet");
         const snippetIndex = $editView.data("snippetIndex");
 
+        if (!editedData.abbreviation || !editedData.abbreviation.trim()) {
+            return;
+        }
+        if (!editedData.templateText || !editedData.templateText.trim()) {
+            return;
+        }
+
         // check if abbreviation changed and if new abbreviation already exists
         if (editedData.abbreviation !== originalSnippet.abbreviation) {
             const existingSnippet = Global.SnippetHintsList.find(

src/extensionsIntegrated/CustomSnippets/src/helper.js

@@ -35,7 +35,7 @@ define(function (require, exports, module) {
         const $abbrInput = $("#abbr-box");
         const $templateInput = $("#template-text-box");
 
-        const $saveBtn = $("#save-custom-snippet-btn").find("button");
+        const $saveBtn = $("#save-custom-snippet-btn button");
 
         // make sure that the required fields has some value
         const hasAbbr = $abbrInput.val().trim().length > 0;

src/styles/Extn-CustomSnippets.less

@@ -580,6 +580,21 @@
         .dark & {
             border-top: 1px solid @dark-bc-panel-separator;
         }
+
+        button:disabled {
+            pointer-events: none !important;
+
+            &:hover,
+            &:focus,
+            &:active,
+            &:visited {
+                background: inherit !important;
+                color: inherit !important;
+                border-color: inherit !important;
+                box-shadow: inherit !important;
+                transform: none !important;
+            }
+        }
     }
 }
 
@@ -745,5 +760,20 @@
         .dark & {
             border-top: 1px solid @dark-bc-panel-separator;
         }
+
+        button:disabled {
+            pointer-events: none !important;
+
+            &:hover,
+            &:focus,
+            &:active,
+            &:visited {
+                background: inherit !important;
+                color: inherit !important;
+                border-color: inherit !important;
+                box-shadow: inherit !important;
+                transform: none !important;
+            }
+        }
     }
 }