fix: accidental download count reset in github actions

Author: abose

build/downloadCounts.js

@@ -31,8 +31,20 @@ function computeTotalDownloads(releases) {
     return {totalInstallerDownloads, totalUpdaterDownloads};
 }
 
+function isRunningInGitHubActions() {
+    return process.env.GITHUB_ACTIONS === 'true';
+}
+
 const DOWNLOAD_COUNTS_URL = "https://public-stats.phcode.io/generated/download_counts.json";
 async function getCurrentDownloadData() {
+    if(isRunningInGitHubActions()){
+        // in github actions, there can be times when fetch fails in the automated hourly
+        // workflows. In that case we should fail early, else it will reset the history
+        // if we do try catch and return null. We dont want automated workflows resetting
+        // history.
+        const fetchedData = await fetch(DOWNLOAD_COUNTS_URL);
+        return fetchedData.json();
+    }
     try{
         const fetchedData = await fetch(DOWNLOAD_COUNTS_URL);
         return await fetchedData.json();

build/index.js

@@ -51,8 +51,8 @@ async function updateDocs() {
     // for debugging uncomment the below lines  and comment the github fetch line
     // fs.writeFileSync('temp/release.json', JSON.stringify(releases, null, 2)); // only do this once and comment
     //const releases = JSON.parse(fs.readFileSync('temp/release.json'));
-    downloadCounts.updateDownloadStats(releases);
-    downloadHistory.updateDownloadHistory(releases);
+    await downloadCounts.updateDownloadStats(releases);
+    await downloadHistory.updateDownloadHistory(releases);
 }
 
 updateDocs();