refactor: update-phel-version.php

Author: Chemaclass

build/update-phel-version.php

@@ -4,48 +4,37 @@
  * Update Phel version in config.toml based on installed Phel package version
  */
 
+const VERSION_PATTERN = '/public\s+const\s+string\s+LATEST_VERSION\s*=\s*[\'"]v?(\d+\.\d+\.\d+)[\'"]/';
+const CONFIG_VERSION_PATTERN = '/^phel_version\s*=\s*"[^"]*"/m';
+
 $versionFinderFile = __DIR__ . '/../vendor/phel-lang/phel-lang/src/php/Console/Application/VersionFinder.php';
 $configFile = __DIR__ . '/../config.toml';
 
 if (!file_exists($versionFinderFile)) {
-    echo "Error: VersionFinder.php not found. Make sure phel-lang/phel-lang is installed.\n";
+    fwrite(STDERR, "Error: VersionFinder.php not found. Make sure phel-lang/phel-lang is installed.\n");
     exit(1);
 }
 
 if (!file_exists($configFile)) {
-    echo "Error: config.toml not found\n";
+    fwrite(STDERR, "Error: config.toml not found\n");
     exit(1);
 }
 
-// Read VersionFinder.php to extract LATEST_VERSION constant
-$versionFinderContent = file_get_contents($versionFinderFile);
-
-if (!$versionFinderContent) {
-    echo "Error: Failed to read VersionFinder.php\n";
+$versionFinderContent = @file_get_contents($versionFinderFile);
+if ($versionFinderContent === false) {
+    fwrite(STDERR, "Error: Failed to read VersionFinder.php\n");
     exit(1);
 }
 
-// Extract version from LATEST_VERSION constant
-$phelVersion = null;
-if (preg_match(
-    '/public\s+const\s+string\s+LATEST_VERSION\s*=\s*[\'"]v?(\d+\.\d+\.\d+)[\'"]/',
-    $versionFinderContent,
-    $matches
-)) {
-    $phelVersion = $matches[1];
-}
-
-if (!$phelVersion) {
-    echo "Warning: Could not determine Phel version from VersionFinder.php\n";
+if (!preg_match(VERSION_PATTERN, $versionFinderContent, $matches)) {
+    fwrite(STDERR, "Warning: Could not determine Phel version from VersionFinder.php\n");
     exit(0);
 }
 
-// Read config.toml
+$phelVersion = $matches[1];
 $configContent = file_get_contents($configFile);
-
-// Update version
 $updatedContent = preg_replace(
-    '/^phel_version\s*=\s*"[^"]*"/m',
+    CONFIG_VERSION_PATTERN,
     'phel_version = "' . $phelVersion . '"',
     $configContent
 );
@@ -55,7 +44,9 @@
     exit(0);
 }
 
-// Write updated config
-file_put_contents($configFile, $updatedContent);
+if (@file_put_contents($configFile, $updatedContent) === false) {
+    fwrite(STDERR, "Error: Failed to write config.toml\n");
+    exit(1);
+}
 
 echo "Updated Phel version in config.toml to: $phelVersion\n";