Merge pull request #53 from Renegade334/queue-filter-hotfix

Do not filter non-empty IRC command parameters which cast to boolean false

Author: svpernova09

src/EventQueue.php

@@ -134,7 +134,7 @@ protected function queueRequest(UserEventInterface $event, $command, array $para
     {
         $event->setPrefix($this->prefix);
         $event->setCommand($command);
-        $event->setParams(array_filter($params));
+        $event->setParams(array_filter($params, 'strlen'));
         $this->queue->insert($event, $this->getPriority($command, $params));
     }
 

tests/EventQueueTest.php

@@ -251,4 +251,27 @@ public function testNonDestructiveIteration()
 
         $this->assertEquals([ $event ], $contents);
     }
+
+    /**
+     * Tests that non-empty parameter strings are not truncated.
+     */
+    public function testRequestFilter()
+    {
+        $this->assertNull($this->queue->extract());
+
+        $this->queue->ircMode('#test', '+n', '');
+        $this->queue->ircPrivmsg('TestUser', '0');
+
+        $event = $this->queue->extract();
+        $this->assertInstanceOf('\Phergie\Irc\Event\EventInterface', $event);
+        $this->assertEquals('MODE', $event->getCommand());
+        $this->assertEquals([ '#test', '+n' ], $event->getParams());
+
+        $event = $this->queue->extract();
+        $this->assertInstanceOf('\Phergie\Irc\Event\EventInterface', $event);
+        $this->assertEquals('PRIVMSG', $event->getCommand());
+        $this->assertEquals([ 'TestUser', '0' ], $event->getParams());
+
+        $this->assertNull($this->queue->extract());
+    }
 }