Dataview and Tasks performance issues

[hpr1999]

Hi there, nice plugin.

I'm not sure whether to raise this here or with Dataview, but I've discovered that enabling this plugin can cause some of my dataview tables to render about 3x slower.

I've prepared a test vault.
test.zip

Just open on Dataview.md, wait for it to render. This takes about 3 seconds on my machine.
Then, open another file and enable the plugin.
Finally, open Dataview.md again. This takes about 9 seconds on my machine.

Thanks for your time :)

(I have also raised this with a certain theme which makes this problem even worse - but my times here were tested with the default theme.)

[bwydoogh]

Encountering the same issue.

I don't know if this plugin is still maintained 🤷‍♂️.

[KraXen72]

i have rewritten significant parts of this plugin here and i am waiting for it's approval here. Feel free to use my improved version, as i plan to maintain it further.

[bwydoogh]

I tried your version, but I am not noticing any performance improvement with regards to Dataview. If I can help any further, let me know.

[KraXen72]

interesting, i thought the rewrite would help. i can test it later and let you know if i figured it out or if you could test some stuff further.

[claremacrae]

Similarly, I had noticed that the Tasks plugin's rendering of task search results had slowed down for me recently.

Some hours of profiling and experimenting has revealed that this plugin was increasing the time to show 1,000 tasks in a search:

• from: 1.1 seconds
• to 4.2 seconds

I get this warning when profiling, once per task rendered:

The purple is the majority of the per-task render time - and clicking on the warning gives this - note the reference to EmojiMarkdownPostProcessor:

[KraXen72]

i guess for my version I can add toggle & a warning for the markdown pre-processor, as well as (by default) not apply it to tasks or dataview elements. any other ideas?

[claremacrae]

The following is speculation based on no knowledge of the intention of this plugin but.... 😄

It seems to me that the purpose of this plugin is to help users to display emojis in text that they are typing....

In which case, it's not obvious to me that this plugin should act on any code blocks at all???

In other words, should it just ignore any code blocks?

[claremacrae]

@hpr1999 May I please ask a favour. Would you be willing edit the title of this report to say 'Dataview and Tasks' for visibility...

I considered adding a second issue, but that just seemed like diluting info....

[KraXen72]

@claremacrae I've logged out the elements the emojiPostProcessor encounters, and it's just a bunch of divs and spans that get rendered either by obsidian or by dataview, so i can't easily filter and skip them.
I'm looking if i can speed up the processor somehow in my fork emoji-autocomplete - (it's published on the obsidian plugin store already, and is a superset of this plugin.)

[KraXen72]

@claremacrae @bwydoogh I've just released version 1.4.0 of emoji-autocomplete, which adds a bunch of optimizations to the EmojiMarkdownProcessor. Please test it out and let me know if the performance has improved. Thanks!

[claremacrae]

@KraXen72 Many thanks for this. I will test it out when I can, but am very busy at the moment.

[bwydoogh]

@claremacrae @bwydoogh I've just released version 1.4.0 of emoji-autocomplete, which adds a bunch of optimizations to the EmojiMarkdownProcessor. Please test it out and let me know if the performance has improved. Thanks!

Performance is better, but I disabled it again; when editing a task for example ... still a lot of lag.

[KraXen72]

i have only tested it with the dataview plugin, for which it improved. i'll try to see what causes the lag for tasks specifically.