fix(tests): update hook execution test to use lambda and improve mock behavior

Author: daantimmer

cucumber_cpp/library/engine/HookExecutor.cpp

@@ -9,6 +9,7 @@
 #include <set>
 #include <stdexcept>
 #include <string>
+#include <utility>
 
 namespace cucumber_cpp::library::engine
 {
@@ -26,17 +27,14 @@ namespace cucumber_cpp::library::engine
 
         struct ThrowPolicy
         {
-        protected:
-            ~ThrowPolicy() = default;
-
-        public:
+            virtual ~ThrowPolicy() = default;
             virtual void Throw() const = 0;
         };
 
         struct ThrowExceptionPolicy : ThrowPolicy
         {
-            ThrowExceptionPolicy(std::string message)
-                : message{ message }
+            explicit ThrowExceptionPolicy(std::string message)
+                : message{ std::move(message) }
             {}
 
             void Throw() const override

cucumber_cpp/library/engine/test/TestHookExecutor.cpp

@@ -77,6 +77,9 @@ namespace cucumber_cpp::library::engine
         report::test_helper::ReportForwarderMock reportHandler{ *contextManagerInstance };
         TestAssertionHandlerImpl assertionHandler{ *contextManagerInstance, reportHandler };
 
-        EXPECT_ANY_THROW(auto scope = hookExecutor->StepStart());
+        EXPECT_ANY_THROW([this]
+            {
+                auto hook = hookExecutor->StepStart();
+            }());
     }
 }

cucumber_cpp/library/engine/test/TestTestRunner.cpp

@@ -80,7 +80,7 @@ namespace cucumber_cpp::library::engine
 
     struct TestTestRunner : testing::Test
     {
-        TestExecutionMockInstance testExecutionMock;
+        testing::StrictMock<TestExecutionMockInstance> testExecutionMock;
         TestRunnerImpl runner{ testExecutionMock };
 
         FeatureTreeFactory featureTreeFactory;
@@ -110,6 +110,18 @@ namespace cucumber_cpp::library::engine
         runner.Run(features);
     }
 
+    TEST_F(TestTestRunner, DontRunEmptyFeature)
+    {
+        EXPECT_CALL(testExecutionMock, StartRunMock);
+        EXPECT_CALL(testExecutionMock, StartFeatureMock).Times(0);
+
+        auto tmp = test_helper::TemporaryFile{ "tmpfile.feature" };
+        tmp << "Feature: Test feature\n";
+        features.push_back(featureTreeFactory.Create(tmp.Path(), ""));
+
+        runner.Run(features);
+    }
+
     TEST_F(TestTestRunner, StartFeatureContextForEveryFeature)
     {
         EXPECT_CALL(testExecutionMock, StartRunMock);