refactor: remove unused functions

Author: daantimmer

cucumber_cpp/library/Application.cpp

@@ -39,16 +39,6 @@ namespace cucumber_cpp::library
 {
     namespace
     {
-        std::string_view const_char_to_sv(const char* value)
-        {
-            return { value };
-        }
-
-        std::string_view subrange_to_sv(const auto& subrange)
-        {
-            return { std::data(subrange), std::data(subrange) + std::size(subrange) };
-        }
-
         template<class Range>
         std::string Join(const Range& range, std::string_view delim)
         {
@@ -57,26 +47,16 @@ namespace cucumber_cpp::library
 
             return std::accumulate(std::next(range.begin()), range.end(), range.front(), [&delim](const auto& lhs, const auto& rhs)
                 {
-                    std::string join;
-                    join.reserve(lhs.size() + delim.size() + rhs.size());
-                    join.append(lhs);
-                    join.append(delim);
-                    join.append(rhs);
-                    return join;
+                    return std::format("{}{}{}", lhs, delim, rhs);
                 });
         }
 
-        std::string JoinStringWithSpace(const std::string& a, const std::string& b)
-        {
-            return a + ' ' + b;
-        }
-
-        std::filesystem::path to_fs_path(const std::string_view& sv)
+        std::filesystem::path ToFileSystemPath(const std::string_view& sv)
         {
             return { sv };
         }
 
-        bool is_feature_file(const std::filesystem::directory_entry& entry)
+        bool IsFeatureFile(const std::filesystem::directory_entry& entry)
         {
             return std::filesystem::is_regular_file(entry) && entry.path().has_extension() && entry.path().extension() == ".feature";
         }
@@ -85,9 +65,9 @@ namespace cucumber_cpp::library
         {
             std::vector<std::filesystem::path> files;
 
-            for (const auto feature : options.features | std::views::transform(to_fs_path))
+            for (const auto feature : options.features | std::views::transform(ToFileSystemPath))
                 if (std::filesystem::is_directory(feature))
-                    for (const auto& entry : std::filesystem::directory_iterator{ feature } | std::views::filter(is_feature_file))
+                    for (const auto& entry : std::filesystem::directory_iterator{ feature } | std::views::filter(IsFeatureFile))
                         files.emplace_back(entry.path());
                 else
                     files.emplace_back(feature);
@@ -107,26 +87,7 @@ namespace cucumber_cpp::library
                   else
                       return std::string{};
               })
-    {
-    }
-
-    ResultStatus& ResultStatus::operator=(Result result)
-    {
-        if ((resultStatus == Result::undefined || resultStatus == Result::passed) && result != Result::undefined)
-            resultStatus = result;
-
-        return *this;
-    }
-
-    ResultStatus::operator Result() const
-    {
-        return resultStatus;
-    }
-
-    bool ResultStatus::IsSuccess() const
-    {
-        return resultStatus == Result::passed;
-    }
+    {}
 
     Application::Application(std::shared_ptr<ContextStorageFactory> contextStorageFactory)
         : contextManager{ std::move(contextStorageFactory) }

cucumber_cpp/library/Application.hpp

@@ -25,19 +25,6 @@ namespace cucumber_cpp::library
         explicit ReportHandlerValidator(const report::Reporters& reporters);
     };
 
-    struct ResultStatus
-    {
-        using Result = engine::Result;
-
-        ResultStatus& operator=(Result result);
-        explicit operator Result() const;
-
-        [[nodiscard]] bool IsSuccess() const;
-
-    private:
-        Result resultStatus{ Result::undefined };
-    };
-
     struct Application
     {
         struct Options