chore: print summy after test run ends

Author: daantimmer

cucumber_cpp/acceptance_test/features/test_fail_feature.feature

@@ -0,0 +1,15 @@
+@fail_feature
+Feature: Simple feature file
+    Background:
+        Given a background step
+
+    Scenario: A failing scenario
+        Given a given step
+        When a when step
+        Then an assertion is raised
+        Then a then step
+
+    Scenario: An OK scenario
+        Given a given step
+        When a when step
+        Then a then step

cucumber_cpp/acceptance_test/test.bats

@@ -148,3 +148,9 @@ teardown() {
     run .build/Host/cucumber_cpp/acceptance_test/Debug/cucumber_cpp.acceptance_test run --feature cucumber_cpp/acceptance_test/features --tag "@keyword-asterisk" --report console
     assert_failure
 }
+
+@test "Test passing scenario after failed scenario reports feature as failed" {
+    run .build/Host/cucumber_cpp/acceptance_test/Debug/cucumber_cpp.acceptance_test run --feature cucumber_cpp/acceptance_test/features  --tag "@fail_feature" --report console
+    assert_failure
+    assert_output --partial "tests   : 1/2 passed"
+}

cucumber_cpp/library/engine/TestExecution.cpp

@@ -16,8 +16,11 @@ namespace cucumber_cpp::library::engine
     const DryRunPolicy dryRunPolicy;
     const ExecuteRunPolicy executeRunPolicy;
 
-    TestExecution::ProgramScope::ProgramScope(HookExecutor& hookExecution)
-        : scopedProgramHook{ hookExecution.BeforeAll() }
+    TestExecution::ProgramScope::ProgramScope(cucumber_cpp::engine::ContextManager& contextManager, report::ReportForwarder& reportHandler, HookExecutor& hookExecution)
+        : contextManager{ contextManager }
+        , reportHandler{ reportHandler }
+        , scopedProgramReport{ reportHandler.ProgramStart() }
+        , scopedProgramHook{ hookExecution.BeforeAll() }
     {
     }
 
@@ -66,7 +69,7 @@ namespace cucumber_cpp::library::engine
 
     TestExecution::ProgramScope TestExecutionImpl::StartRun()
     {
-        return ProgramScope{ hookExecution };
+        return ProgramScope{ contextManager, reportHandler, hookExecution };
     }
 
     TestExecution::FeatureScope TestExecutionImpl::StartFeature(const ::cucumber_cpp::engine::FeatureInfo& featureInfo)

cucumber_cpp/library/engine/TestExecution.hpp

@@ -35,9 +35,13 @@ namespace cucumber_cpp::library::engine
 
     struct TestExecution::ProgramScope : library::util::Immoveable
     {
-        ProgramScope(HookExecutor& hookExecution);
+        ProgramScope(cucumber_cpp::engine::ContextManager& contextManager, report::ReportForwarder& reportHandler, HookExecutor& hookExecution);
 
     private:
+        cucumber_cpp::engine::ContextManager& contextManager;
+        report::ReportForwarder& reportHandler;
+
+        report::ReportForwarder::ProgramScope scopedProgramReport;
         HookExecutor::ProgramScope scopedProgramHook;
     };
 

cucumber_cpp/library/report/Report.cpp

@@ -53,6 +53,16 @@ namespace cucumber_cpp::report
         return reporters;
     }
 
+    ReportForwarder::ProgramScope::ProgramScope(cucumber_cpp::engine::ProgramContext& programContext, std::vector<std::unique_ptr<ReportHandlerV2>>& reporters)
+        : programContext{ programContext }
+        , reporters{ reporters }
+    {}
+
+    ReportForwarder::ProgramScope::~ProgramScope()
+    {
+        ForwardCall(reporters, &ReportHandlerV2::Summary, programContext.Duration());
+    }
+
     ReportForwarder::FeatureScope::FeatureScope(cucumber_cpp::engine::FeatureContext& featureContext, std::vector<std::unique_ptr<ReportHandlerV2>>& reporters)
         : featureContext{ featureContext }
         , reporters{ reporters }
@@ -105,6 +115,11 @@ namespace cucumber_cpp::report
         : contextManager{ contextManager }
     {}
 
+    [[nodiscard]] ReportForwarder::ProgramScope ReportForwarderImpl::ProgramStart()
+    {
+        return ProgramScope{ contextManager.ProgramContext(), Storage() };
+    }
+
     ReportForwarder::FeatureScope ReportForwarderImpl::FeatureStart()
     {
         return FeatureScope{ contextManager.FeatureContext(), Storage() };

cucumber_cpp/library/report/Report.hpp

@@ -68,11 +68,13 @@ namespace cucumber_cpp::report
 
     struct ReportForwarder
     {
+        struct ProgramScope;
         struct FeatureScope;
         struct RuleScope;
         struct ScenarioScope;
         struct StepScope;
 
+        [[nodiscard]] virtual ProgramScope ProgramStart() = 0;
         [[nodiscard]] virtual FeatureScope FeatureStart() = 0;
         [[nodiscard]] virtual RuleScope RuleStart() = 0;
         [[nodiscard]] virtual ScenarioScope ScenarioStart() = 0;
@@ -88,6 +90,16 @@ namespace cucumber_cpp::report
         virtual void Summary(TraceTime::Duration duration) = 0;
     };
 
+    struct ReportForwarder::ProgramScope
+    {
+        ProgramScope(cucumber_cpp::engine::ProgramContext& programContext, std::vector<std::unique_ptr<ReportHandlerV2>>& reporters);
+        ~ProgramScope();
+
+    private:
+        cucumber_cpp::engine::ProgramContext& programContext;
+        std::vector<std::unique_ptr<ReportHandlerV2>>& reporters;
+    };
+
     struct ReportForwarder::FeatureScope
     {
         FeatureScope(cucumber_cpp::engine::FeatureContext& featureContext, std::vector<std::unique_ptr<ReportHandlerV2>>& reporters);
@@ -134,6 +146,7 @@ namespace cucumber_cpp::report
     {
         explicit ReportForwarderImpl(cucumber_cpp::engine::ContextManager& contextManager);
 
+        [[nodiscard]] ProgramScope ProgramStart() override;
         [[nodiscard]] FeatureScope FeatureStart() override;
         [[nodiscard]] RuleScope RuleStart() override;
         [[nodiscard]] ScenarioScope ScenarioStart() override;