fix windows build issues

Author: daantimmer

cucumber_cpp/library/tag_expression/Model.hpp

@@ -10,6 +10,8 @@ namespace cucumber_cpp::library::tag_expression
 {
     struct Expression
     {
+        virtual ~Expression() = default;
+
         virtual bool Evaluate(const std::set<std::string, std::less<>>& tags) const = 0;
         virtual operator std::string() const = 0;
     };

cucumber_cpp/library/tag_expression/test/TestErrors.cpp

@@ -8,7 +8,7 @@ namespace cucumber_cpp::library::tag_expression
 {
     struct TestErrors : testing::Test
     {
-        void ExpectErrror(std::string_view expression, std::string_view error)
+        void ExpectError(std::string_view expression, std::string_view error)
         {
             ASSERT_THROW(try { TagExpressionParser{}.Parse(expression); } catch (const TagExpressionError& ex) {
                 std::cout << "expected: " << error << "\n";
@@ -20,57 +20,57 @@ namespace cucumber_cpp::library::tag_expression
 
     TEST_F(TestErrors, ParseFailsWithUnbalancedParens)
     {
-        ExpectErrror("( a and b ))", "Missing '(': Too few open-parens");
-        ExpectErrror("( ( a and b )", "Unclosed '(': Too many open-parens");
+        ExpectError("( a and b ))", "Missing '(': Too few open-parens");
+        ExpectError("( ( a and b )", "Unclosed '(': Too many open-parens");
     }
 
     TEST_F(TestErrors, ParseFailsWithMissingOperationArgs)
     {
-        ExpectErrror("a not ( and )", "Syntax error. Expected operator after a");
+        ExpectError("a not ( and )", "Syntax error. Expected operator after a");
     }
 
     TEST_F(TestErrors, ParseFailsWithOnlyOperations)
     {
-        ExpectErrror("or or", "Syntax error. Expected operand after BEGIN");
+        ExpectError("or or", "Syntax error. Expected operand after BEGIN");
     }
 
     TEST_F(TestErrors, ParseFailsForArgsWithoutOperation)
     {
-        ExpectErrror("a b", "Syntax error. Expected operator after a");
+        ExpectError("a b", "Syntax error. Expected operator after a");
     }
 
     TEST_F(TestErrors, ParseFailsForEmptyParensGroups)
     {
-        ExpectErrror("(())", "Syntax error. Expected operand after (");
-        ExpectErrror("(() ())", "Syntax error. Expected operand after (");
+        ExpectError("(())", "Syntax error. Expected operand after (");
+        ExpectError("(() ())", "Syntax error. Expected operand after (");
     }
 
     TEST_F(TestErrors, ParseFailsWithRpnNotation)
     {
-        ExpectErrror("a b or", "Syntax error. Expected operator after a");
-        ExpectErrror("a and (b not)", "Syntax error. Expected operator after b");
-        ExpectErrror("a and (b c) or", "Syntax error. Expected operator after b");
+        ExpectError("a b or", "Syntax error. Expected operator after a");
+        ExpectError("a and (b not)", "Syntax error. Expected operator after b");
+        ExpectError("a and (b c) or", "Syntax error. Expected operator after b");
     }
 
     TEST_F(TestErrors, ParseFailsAndOperationWithTooFewArgs)
     {
-        ExpectErrror("a and ", "and: Too few operands");
-        ExpectErrror("  and b", "Syntax error. Expected operand after BEGIN");
+        ExpectError("a and ", "and: Too few operands");
+        ExpectError("  and b", "Syntax error. Expected operand after BEGIN");
     }
 
     TEST_F(TestErrors, ParseFailsOrOperationWithTooFewArgs)
     {
-        ExpectErrror("a or ", "or: Too few operands");
-        ExpectErrror("  or b", "Syntax error. Expected operand after BEGIN");
-        ExpectErrror("a and b or ", "or: Too few operands");
+        ExpectError("a or ", "or: Too few operands");
+        ExpectError("  or b", "Syntax error. Expected operand after BEGIN");
+        ExpectError("a and b or ", "or: Too few operands");
     }
 
     TEST_F(TestErrors, ParseFailsNotOperationWithTooFewArgs)
     {
-        ExpectErrror("not ", "not: Too few operands");
-        ExpectErrror("not ()", "Syntax error. Expected operand after (");
-        ExpectErrror("not () and b", "Syntax error. Expected operand after (");
-        ExpectErrror("not () or b", "Syntax error. Expected operand after (");
+        ExpectError("not ", "not: Too few operands");
+        ExpectError("not ()", "Syntax error. Expected operand after (");
+        ExpectError("not () and b", "Syntax error. Expected operand after (");
+        ExpectError("not () or b", "Syntax error. Expected operand after (");
     }
 
 }

cucumber_cpp/library/tag_expression/test/TestEvaluations.cpp

@@ -3,7 +3,6 @@
 #include "yaml-cpp/node/node.h"
 #include "yaml-cpp/node/parse.h"
 #include "yaml-cpp/yaml.h"
-#include "gtest/gtest.h"
 #include <cstdlib>
 #include <filesystem>
 #include <format>
@@ -22,7 +21,6 @@ namespace cucumber_cpp::library::tag_expression
     };
 
     struct TestEvaluations : TestEvaluationsFixture
-
     {
         TestEvaluations(std::string_view expression, YAML::Node variables, bool result)
             : expression{ expression }