test: add tests for missing and ambiguous step reporting from Feature Factory

Author: daantimmer

cucumber_cpp/library/engine/test/TestFeatureFactory.cpp

@@ -22,7 +22,7 @@ namespace cucumber_cpp::library::engine
         StepRegistry stepRegistry{ parameterRegistry };
 
         test_helper::ContextManagerInstance contextManager;
-        report::ReportForwarderImpl reportForwarderImpl{ contextManager };
+        report::test_helper::ReportForwarderMock reportForwarderImpl{ contextManager };
         FeatureTreeFactory featureTreeFactory{ stepRegistry, reportForwarderImpl };
     };
 
@@ -315,4 +315,30 @@ namespace cucumber_cpp::library::engine
         EXPECT_THAT(scenario1->Children()[0]->Table()[1][0].As<std::string>(), testing::StrEq("c"));
         EXPECT_THAT(scenario1->Children()[0]->Table()[1][1].As<std::string>(), testing::StrEq("d"));
     }
+
+    TEST_F(TestFeatureFactory, MissingStepsAreReported)
+    {
+        auto tmp = test_helper::TemporaryFile{ "tmpfile.feature" };
+
+        tmp << "Feature: Test feature\n"
+               "  Scenario: Test scenario\n"
+               "    Given this is a missing step\n";
+
+        EXPECT_CALL(reportForwarderImpl, StepMissing);
+
+        const auto feature = featureTreeFactory.Create(tmp.Path(), "");
+    }
+
+    TEST_F(TestFeatureFactory, AmbiguousStepsAreReported)
+    {
+        auto tmp = test_helper::TemporaryFile{ "tmpfile.feature" };
+
+        tmp << "Feature: Test feature\n"
+               "  Scenario: Test scenario\n"
+               "    Given this is ambiguous\n";
+
+        EXPECT_CALL(reportForwarderImpl, StepAmbiguous);
+
+        const auto feature = featureTreeFactory.Create(tmp.Path(), "");
+    }
 }

cucumber_cpp/library/engine/test_helper/StepImplementations.cpp

@@ -110,3 +110,13 @@ THEN(R"(An expression with \\\{escaped braces\\} should keep the slash)")
 {
     /* do nothing */
 }
+
+GIVEN("this is ambiguous")
+{
+    // empty
+}
+
+GIVEN("this is ambiguous( or not)")
+{
+    // empty
+}

cucumber_cpp/library/report/test_helper/ReportForwarderMock.hpp

@@ -1,6 +1,7 @@
 #ifndef TEST_HELPER_REPORTFORWARDERMOCK_HPP
 #define TEST_HELPER_REPORTFORWARDERMOCK_HPP
 
+#include "cucumber_cpp/library/engine/StepInfo.hpp"
 #include "cucumber_cpp/library/report/Report.hpp"
 #include <cstddef>
 #include <filesystem>
@@ -15,6 +16,9 @@ namespace cucumber_cpp::library::report::test_helper
         using ReportForwarderImpl::ReportForwarderImpl;
         virtual ~ReportForwarderMock() = default;
 
+        MOCK_METHOD(void, StepMissing, (const std::string& stepText), (override));
+        MOCK_METHOD(void, StepAmbiguous, (const std::string& stepText, const engine::StepInfo& stepInfo), (override));
+
         MOCK_METHOD(void, Failure, (const std::string& error, std::optional<std::filesystem::path> path, std::optional<std::size_t> line, std::optional<std::size_t> column), (override));
         MOCK_METHOD(void, Error, (const std::string& error, std::optional<std::filesystem::path> path, std::optional<std::size_t> line, std::optional<std::size_t> column), (override));
     };