chore: revert IsEscapeCharacter unsigned change (#253)

daantimmer · web-flow · commit 52d8a5d51d76 · 2025-11-20T23:37:05.000Z
Fixes #230
diff --git a/cucumber_cpp/library/cucumber_expression/Ast.cpp b/cucumber_cpp/library/cucumber_expression/Ast.cpp
@@ -122,7 +122,7 @@ namespace cucumber_cpp::library::cucumber_expression
 
     TokenType Token::TypeOf(char ch)
     {
-        if (std::isspace(ch) != 0)
+        if (std::isspace(static_cast<unsigned char>(ch)) != 0)
             return TokenType::whiteSpace;
 
         if (DemarcationMap().contains(ch))
@@ -133,7 +133,7 @@ namespace cucumber_cpp::library::cucumber_expression
 
     bool Token::CanEscape(char ch)
     {
-        if (std::isspace(ch) != 0)
+        if (std::isspace(static_cast<unsigned char>(ch)) != 0)
             return true;
 
         return ch == '\\' || DemarcationMap().contains(ch);

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ namespace cucumber_cpp::library::cucumber_expression`
`122`	`122`
`123`	`123`	`TokenType Token::TypeOf(char ch)`
`124`	`124`	`{`
`125`		`- if (std::isspace(ch) != 0)`
	`125`	`+ if (std::isspace(static_cast<unsigned char>(ch)) != 0)`
`126`	`126`	`return TokenType::whiteSpace;`
`127`	`127`
`128`	`128`	`if (DemarcationMap().contains(ch))`
`@@ -133,7 +133,7 @@ namespace cucumber_cpp::library::cucumber_expression`
`133`	`133`
`134`	`134`	`bool Token::CanEscape(char ch)`
`135`	`135`	`{`
`136`		`- if (std::isspace(ch) != 0)`
	`136`	`+ if (std::isspace(static_cast<unsigned char>(ch)) != 0)`
`137`	`137`	`return true;`
`138`	`138`
`139`	`139`	`return ch == '\\' \|\| DemarcationMap().contains(ch);`