add tests for Token's HasLowerPrecedenceThan

Author: daantimmer

cucumber_cpp/library/tag_expression/Token.cpp

@@ -7,11 +7,6 @@ namespace cucumber_cpp::library::tag_expression
         return type == TokenType::operator_;
     }
 
-    bool Token::IsBinary() const
-    {
-        return *this == OR || *this == AND;
-    }
-
     bool Token::IsUnary() const
     {
         return *this == NOT;

cucumber_cpp/library/tag_expression/Token.hpp

@@ -42,7 +42,6 @@ namespace cucumber_cpp::library::tag_expression
         {}
 
         bool IsOperation() const;
-        bool IsBinary() const;
         bool IsUnary() const;
 
         bool HasLowerPrecedenceThan(const Token& other) const;

cucumber_cpp/library/tag_expression/test/CMakeLists.txt

@@ -12,6 +12,7 @@ target_sources(cucumber_cpp.library.tag_expression.test PRIVATE
     TestErrors.cpp
     TestEvaluations.cpp
     TestParsing.cpp
+    TestToken.cpp
 )
 
 add_custom_command(

cucumber_cpp/library/tag_expression/test/TestToken.cpp

@@ -0,0 +1,31 @@
+
+#include "cucumber_cpp/library/tag_expression/Token.hpp"
+#include "gmock/gmock.h"
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+
+namespace cucumber_cpp::library::tag_expression
+{
+    TEST(TestToken, TestPrecedence)
+    {
+        EXPECT_THAT(OR.HasLowerPrecedenceThan(OR), testing::IsTrue());
+        EXPECT_THAT(OR.HasLowerPrecedenceThan(AND), testing::IsTrue());
+        EXPECT_THAT(OR.HasLowerPrecedenceThan(NOT), testing::IsTrue());
+        EXPECT_THAT(AND.HasLowerPrecedenceThan(AND), testing::IsTrue());
+        EXPECT_THAT(AND.HasLowerPrecedenceThan(OR), testing::IsFalse());
+        EXPECT_THAT(AND.HasLowerPrecedenceThan(NOT), testing::IsTrue());
+        EXPECT_THAT(NOT.HasLowerPrecedenceThan(NOT), testing::IsFalse());
+        EXPECT_THAT(NOT.HasLowerPrecedenceThan(OR), testing::IsFalse());
+        EXPECT_THAT(NOT.HasLowerPrecedenceThan(AND), testing::IsFalse());
+    }
+
+    TEST(TestToken, TestPrecedenceWithParenthesis)
+    {
+        EXPECT_THAT(OR.HasLowerPrecedenceThan(OPEN_PARENTHESIS), testing::IsFalse());
+        EXPECT_THAT(OR.HasLowerPrecedenceThan(CLOSE_PARENTHESIS), testing::IsFalse());
+        EXPECT_THAT(AND.HasLowerPrecedenceThan(OPEN_PARENTHESIS), testing::IsFalse());
+        EXPECT_THAT(AND.HasLowerPrecedenceThan(CLOSE_PARENTHESIS), testing::IsFalse());
+        EXPECT_THAT(NOT.HasLowerPrecedenceThan(OPEN_PARENTHESIS), testing::IsFalse());
+        EXPECT_THAT(NOT.HasLowerPrecedenceThan(CLOSE_PARENTHESIS), testing::IsFalse());
+    }
+}