chore: remove unused includes and commented code in HookExecutor

daantimmer · daantimmer · commit a17ce9b0fc73 · 2025-06-11T08:47:03.000Z
diff --git a/cucumber_cpp/library/engine/HookExecutor.cpp b/cucumber_cpp/library/engine/HookExecutor.cpp
@@ -6,11 +6,8 @@
 #include "cucumber_cpp/library/engine/ScenarioInfo.hpp"
 #include "cucumber_cpp/library/engine/StepInfo.hpp"
 #include <functional>
-#include <optional>
 #include <set>
-#include <stdexcept>
 #include <string>
-#include <utility>
 
 namespace cucumber_cpp::library::engine
 {
@@ -37,15 +34,12 @@ namespace cucumber_cpp::library::engine
         : runnerContext{ runnerContext }
         , hookPair{ hookPair }
         , tags{ tags }
-    // , executeHooks{ runnerContext.InheritedExecutionStatus() == Result::passed }
     {
-        // if (executeHooks)
         ExecuteHook(runnerContext, hookPair.before, tags);
     }
 
     HookExecutor::ScopedHook::~ScopedHook()
     {
-        // if (executeHooks)
         ExecuteHook(runnerContext, hookPair.after, tags);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,8 @@`
`6`	`6`	`#include "cucumber_cpp/library/engine/ScenarioInfo.hpp"`
`7`	`7`	`#include "cucumber_cpp/library/engine/StepInfo.hpp"`
`8`	`8`	`#include <functional>`
`9`		`-#include <optional>`
`10`	`9`	`#include <set>`
`11`		`-#include <stdexcept>`
`12`	`10`	`#include <string>`
`13`		`-#include <utility>`
`14`	`11`
`15`	`12`	`namespace cucumber_cpp::library::engine`
`16`	`13`	`{`
`@@ -37,15 +34,12 @@ namespace cucumber_cpp::library::engine`
`37`	`34`	`: runnerContext{ runnerContext }`
`38`	`35`	`, hookPair{ hookPair }`
`39`	`36`	`, tags{ tags }`
`40`		`- // , executeHooks{ runnerContext.InheritedExecutionStatus() == Result::passed }`
`41`	`37`	`{`
`42`		`- // if (executeHooks)`
`43`	`38`	`ExecuteHook(runnerContext, hookPair.before, tags);`
`44`	`39`	`}`
`45`	`40`
`46`	`41`	`HookExecutor::ScopedHook::~ScopedHook()`
`47`	`42`	`{`
`48`		`- // if (executeHooks)`
`49`	`43`	`ExecuteHook(runnerContext, hookPair.after, tags);`
`50`	`44`	`}`
`51`	`45`