remove unused stuff

Author: daantimmer

cucumber_cpp/library/formatter/helper/GherkinDocumentParser.cpp

@@ -2,14 +2,11 @@
 #include "cucumber/messages/background.hpp"
 #include "cucumber/messages/feature_child.hpp"
 #include "cucumber/messages/gherkin_document.hpp"
-#include "cucumber/messages/location.hpp"
 #include "cucumber/messages/rule.hpp"
 #include "cucumber/messages/rule_child.hpp"
 #include "cucumber/messages/scenario.hpp"
 #include "cucumber/messages/step.hpp"
-#include <map>
 #include <ranges>
-#include <string>
 #include <variant>
 #include <vector>
 
@@ -92,22 +89,6 @@ namespace cucumber_cpp::library::formatter::helper
         return map;
     }
 
-    GherkinScenarioRuleMap GetGherkinScenarioRuleMap(const cucumber::messages::gherkin_document& gherkinDocument)
-    {
-        auto rules = gherkinDocument.feature->children | std::views::transform(ExtractRulesFeatureChild) | std::views::join;
-
-        GherkinScenarioRuleMap map;
-
-        for (const auto& rule : rules)
-        {
-            auto scenarios = rule.children | std::views::transform(ExtractScenarioFromRuleChild) | std::views::join;
-            for (const auto& scenario : scenarios)
-                map.emplace(scenario.id, rule);
-        }
-
-        return map;
-    }
-
     GherkinScenarioMap GetGherkinScenarioMap(const cucumber::messages::gherkin_document& gherkinDocument)
     {
         GherkinScenarioMap map;

cucumber_cpp/library/formatter/helper/GherkinDocumentParser.hpp

@@ -1,10 +1,8 @@
 #ifndef HELPER_GHERKIN_DOCUMENT_PARSER_HPP
 #define HELPER_GHERKIN_DOCUMENT_PARSER_HPP
 
-#include "cucumber/messages/feature.hpp"
 #include "cucumber/messages/gherkin_document.hpp"
 #include "cucumber/messages/location.hpp"
-#include "cucumber/messages/rule.hpp"
 #include "cucumber/messages/scenario.hpp"
 #include "cucumber/messages/step.hpp"
 #include <map>
@@ -13,12 +11,10 @@
 namespace cucumber_cpp::library::formatter::helper
 {
     using GherkinStepMap = std::map<std::string, cucumber::messages::step>;
-    using GherkinScenarioRuleMap = std::map<std::string, cucumber::messages::rule>;
     using GherkinScenarioMap = std::map<std::string, cucumber::messages::scenario>;
     using GherkinScenarioLocationMap = std::map<std::string, cucumber::messages::location>;
 
     GherkinStepMap GetGherkinStepMap(const cucumber::messages::gherkin_document& gherkinDocument);
-    GherkinScenarioRuleMap GetGherkinScenarioRuleMap(const cucumber::messages::gherkin_document& gherkinDocument);
     GherkinScenarioMap GetGherkinScenarioMap(const cucumber::messages::gherkin_document& gherkinDocument);
     GherkinScenarioLocationMap GetGherkinScenarioLocationMap(const cucumber::messages::gherkin_document& gherkinDocument);
 }

cucumber_cpp/library/runtime/Worker.cpp

@@ -56,7 +56,7 @@ namespace cucumber_cpp::library::runtime
             return to_underlying(a.status) < to_underlying(b.status);
         };
 
-        inline std::set<cucumber::messages::test_step_result_status> failingStatuses{
+        const inline std::set<cucumber::messages::test_step_result_status> failingStatuses{
             cucumber::messages::test_step_result_status::AMBIGUOUS,
             cucumber::messages::test_step_result_status::FAILED,
             cucumber::messages::test_step_result_status::UNDEFINED,
@@ -160,10 +160,10 @@ namespace cucumber_cpp::library::runtime
     cucumber::messages::test_step_result Worker::RunTestHook(std::string id, Context& context)
     {
         const auto& definition = supportCodeLibrary.hookRegistry.GetDefinitionById(id);
-        const auto testRunHookStartedid = idGenerator->next_id();
+        const auto testRunHookStartedId = idGenerator->next_id();
 
         const auto testRunHookStarted = cucumber::messages::test_run_hook_started{
-            .id = testRunHookStartedid,
+            .id = testRunHookStartedId,
             .test_run_started_id = std::string{ testRunStartedId },
             .hook_id = definition.hook.id,
             .timestamp = support::TimestampNow(),
@@ -174,7 +174,7 @@ namespace cucumber_cpp::library::runtime
         auto result = definition.factory(broadcaster, context, testRunHookStarted)->ExecuteAndCatchExceptions();
 
         broadcaster.BroadcastEvent({ .test_run_hook_finished = cucumber::messages::test_run_hook_finished{
-                                         .test_run_hook_started_id = testRunHookStartedid,
+                                         .test_run_hook_started_id = testRunHookStartedId,
                                          .result = result,
                                          .timestamp = support::TimestampNow(),
                                      } });