Skip to content

Commit c67ebd4

Browse files
committed
fixed TestExpression tests
1 parent 78f70e1 commit c67ebd4

File tree

1 file changed

+16
-24
lines changed

1 file changed

+16
-24
lines changed

cucumber_cpp/library/cucumber_expression/test/TestExpression.cpp

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -98,50 +98,42 @@ namespace cucumber_cpp::library::cucumber_expression
9898
const auto actualValue = argument.Name() == "string" ? argument.GetValue<std::string>() : argument.Group().value.value();
9999
const auto expectedValue = testdata["expected_args"][i].as<std::string>();
100100

101-
if (argument.Name() == "int")
101+
if (argument.Name() == "")
102+
EXPECT_THAT(argument.GetValue<std::string>(), testdata["expected_args"][i].as<std::string>()) << FormatMessage(file, testdata, expression);
103+
104+
else if (argument.Name() == "int")
102105
EXPECT_THAT(argument.GetValue<std::int32_t>(), testdata["expected_args"][i].as<std::int32_t>()) << FormatMessage(file, testdata, expression);
103106

104-
if (argument.Name() == "float")
107+
else if (argument.Name() == "float")
105108
EXPECT_THAT(argument.GetValue<float>(), testdata["expected_args"][i].as<float>()) << FormatMessage(file, testdata, expression);
106109

107-
if (argument.Name() == "word")
110+
else if (argument.Name() == "word")
108111
EXPECT_THAT(argument.GetValue<std::string>(), testdata["expected_args"][i].as<std::string>()) << FormatMessage(file, testdata, expression);
109112

110-
if (argument.Name() == "string")
113+
else if (argument.Name() == "string")
111114
EXPECT_THAT(argument.GetValue<std::string>(), testdata["expected_args"][i].as<std::string>()) << FormatMessage(file, testdata, expression);
112115

113-
if (argument.Name() == "bigdecimal")
116+
else if (argument.Name() == "bigdecimal")
114117
EXPECT_THAT(argument.GetValue<double>(), testdata["expected_args"][i].as<double>()) << FormatMessage(file, testdata, expression);
115118

116-
if (argument.Name() == "biginteger")
119+
else if (argument.Name() == "biginteger")
117120
EXPECT_THAT(argument.GetValue<std::int64_t>(), testdata["expected_args"][i].as<std::int64_t>()) << FormatMessage(file, testdata, expression);
118121

119-
if (argument.Name() == "byte")
122+
else if (argument.Name() == "byte")
120123
EXPECT_THAT(argument.GetValue<std::int32_t>(), testdata["expected_args"][i].as<std::int32_t>()) << FormatMessage(file, testdata, expression);
121124

122-
if (argument.Name() == "short")
125+
else if (argument.Name() == "short")
123126
EXPECT_THAT(argument.GetValue<std::int32_t>(), testdata["expected_args"][i].as<std::int32_t>()) << FormatMessage(file, testdata, expression);
124127

125-
if (argument.Name() == "long")
128+
else if (argument.Name() == "long")
126129
EXPECT_THAT(argument.GetValue<std::int64_t>(), testdata["expected_args"][i].as<std::int64_t>()) << FormatMessage(file, testdata, expression);
127130

128-
if (argument.Name() == "double")
131+
else if (argument.Name() == "double")
129132
EXPECT_THAT(argument.GetValue<double>(), testdata["expected_args"][i].as<double>()) << FormatMessage(file, testdata, expression);
130133

131-
// if (match[i].type() == typeid(std::string))
132-
// ASSERT_THAT(std::any_cast<std::string>(match[i]), testdata["expected_args"][i].as<std::string>())
133-
// << FormatMessage(testdata, expression);
134-
// else if (match[i].type() == typeid(std::int32_t))
135-
// ASSERT_THAT(std::any_cast<std::int32_t>(match[i]), testdata["expected_args"][i].as<std::int32_t>()) << FormatMessage(testdata, expression);
136-
// else if (match[i].type() == typeid(std::int64_t))
137-
// ASSERT_THAT(std::any_cast<std::int64_t>(match[i]), testdata["expected_args"][i].as<std::int64_t>()) << FormatMessage(testdata, expression);
138-
// else if (match[i].type() == typeid(float))
139-
// ASSERT_THAT(std::any_cast<float>(match[i]), testdata["expected_args"][i].as<float>()) << FormatMessage(testdata, expression);
140-
// else if (match[i].type() == typeid(double))
141-
// ASSERT_THAT(std::any_cast<double>(match[i]), testdata["expected_args"][i].as<double>()) << FormatMessage(testdata, expression);
142-
// else
143-
// FAIL() << "Unknown type: " << match[i].type().name() << " for:\n"
144-
// << FormatMessage(testdata, expression);
134+
else
135+
FAIL() << "Unknown type: " << argument.Name() << " for:\n"
136+
<< FormatMessage(file, testdata, expression);
145137
}
146138
}
147139
}

0 commit comments

Comments
 (0)