refactor: use const references for MatchRange in converter functions

daantimmer · daantimmer · commit d2dd8fba913c · 2025-06-11T10:30:20.000Z
diff --git a/cucumber_cpp/library/cucumber_expression/ParameterRegistry.cpp b/cucumber_cpp/library/cucumber_expression/ParameterRegistry.cpp
@@ -22,15 +22,15 @@ namespace cucumber_cpp::library::cucumber_expression
         template<class T>
         std::function<std::any(MatchRange)> CreateStreamConverter()
         {
-            return [](MatchRange matches)
+            return [](const MatchRange& matches)
             {
                 return StringTo<T>(matches.begin()->str());
             };
         }
 
         std::function<std::any(MatchRange)> CreateStringConverter()
         {
-            return [](MatchRange matches)
+            return [](const MatchRange& matches)
             {
                 std::string str = matches[1].matched ? matches[1].str() : matches[3].str();
                 str = std::regex_replace(str, std::regex(R"__(\\")__"), "\"");

Original file line number	Diff line number	Diff line change
`@@ -22,15 +22,15 @@ namespace cucumber_cpp::library::cucumber_expression`
`22`	`22`	`template<class T>`
`23`	`23`	`std::function<std::any(MatchRange)> CreateStreamConverter()`
`24`	`24`	`{`
`25`		`- return [](MatchRange matches)`
	`25`	`+ return [](const MatchRange& matches)`
`26`	`26`	`{`
`27`	`27`	`return StringTo<T>(matches.begin()->str());`
`28`	`28`	`};`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`std::function<std::any(MatchRange)> CreateStringConverter()`
`32`	`32`	`{`
`33`		`- return [](MatchRange matches)`
	`33`	`+ return [](const MatchRange& matches)`
`34`	`34`	`{`
`35`	`35`	`std::string str = matches[1].matched ? matches[1].str() : matches[3].str();`
`36`	`36`	`str = std::regex_replace(str, std::regex(R"__(\\")__"), "\"");`