refactor: change character type from char to unsigned char in Token methods for consistency

Author: daantimmer

cucumber_cpp/library/cucumber_expression/Ast.cpp

@@ -23,18 +23,6 @@ namespace cucumber_cpp::library::cucumber_expression
 
             return demarcationMap;
         }
-
-        const std::map<TokenType, std::string>& TokenTypeMap()
-        {
-            static const std::map<TokenType, std::string> tokenTypeMap = {
-                { TokenType::alternation, "alternation" },
-                { TokenType::beginParameter, "beginParameter" },
-                { TokenType::endParameter, "endParameter" },
-                { TokenType::beginOptional, "beginOptional" },
-                { TokenType::endOptional, "endOptional" },
-            };
-            return tokenTypeMap;
-        }
     }
 
     std::string Node::Text()
@@ -68,12 +56,12 @@ namespace cucumber_cpp::library::cucumber_expression
         return std::get<std::vector<Node>>(children);
     }
 
-    bool Token::IsEscapeCharacter(char ch)
+    bool Token::IsEscapeCharacter(unsigned char ch)
     {
         return ch == '\\';
     }
 
-    TokenType Token::TypeOf(char ch)
+    TokenType Token::TypeOf(unsigned char ch)
     {
         if (std::isspace(ch) != 0)
             return TokenType::whiteSpace;
@@ -84,7 +72,7 @@ namespace cucumber_cpp::library::cucumber_expression
         return TokenType::text;
     }
 
-    bool Token::CanEscape(char ch)
+    bool Token::CanEscape(unsigned char ch)
     {
         if (std::isspace(ch) != 0)
             return true;

cucumber_cpp/library/cucumber_expression/Ast.hpp

@@ -57,9 +57,9 @@ namespace cucumber_cpp::library::cucumber_expression
 
         bool operator==(const Token& other) const = default;
 
-        static bool IsEscapeCharacter(char ch);
-        static TokenType TypeOf(char ch);
-        static bool CanEscape(char ch);
+        static bool IsEscapeCharacter(unsigned char ch);
+        static TokenType TypeOf(unsigned char ch);
+        static bool CanEscape(unsigned char ch);
         static std::string NameOf(TokenType type);
         static std::string SymbolOf(TokenType type);
         static std::string PurposeOf(TokenType type);