Skip to content

Commit e31ca66

Browse files
committed
chore: revert IsEscapeCharacter unsigned change
Fixes #230
1 parent e55fbe5 commit e31ca66

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cucumber_cpp/library/cucumber_expression/Ast.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,12 @@ namespace cucumber_cpp::library::cucumber_expression
115115
return end;
116116
}
117117

118-
bool Token::IsEscapeCharacter(char ch)
118+
bool Token::IsEscapeCharacter(unsigned char ch)
119119
{
120120
return ch == '\\';
121121
}
122122

123-
TokenType Token::TypeOf(char ch)
123+
TokenType Token::TypeOf(unsigned char ch)
124124
{
125125
if (std::isspace(ch) != 0)
126126
return TokenType::whiteSpace;
@@ -131,7 +131,7 @@ namespace cucumber_cpp::library::cucumber_expression
131131
return TokenType::text;
132132
}
133133

134-
bool Token::CanEscape(char ch)
134+
bool Token::CanEscape(unsigned char ch)
135135
{
136136
if (std::isspace(ch) != 0)
137137
return true;

cucumber_cpp/library/cucumber_expression/Ast.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ namespace cucumber_cpp::library::cucumber_expression
6969
std::size_t Start() const;
7070
std::size_t End() const;
7171

72-
static bool IsEscapeCharacter(char ch);
73-
static TokenType TypeOf(char ch);
74-
static bool CanEscape(char ch);
72+
static bool IsEscapeCharacter(unsigned char ch);
73+
static TokenType TypeOf(unsigned char ch);
74+
static bool CanEscape(unsigned char ch);
7575
static std::string NameOf(TokenType type);
7676
static std::string SymbolOf(TokenType type);
7777
static std::string PurposeOf(TokenType type);

0 commit comments

Comments
 (0)