Skip to content

Commit 35f99f8

Browse files
authored
ci: remove upload documents from matrix job (#959)
* ci: remove upload documents from matrix job * chore: fix zizmor findings
1 parent b67d2bc commit 35f99f8

File tree

1 file changed

+25
-10
lines changed

1 file changed

+25
-10
lines changed

.github/workflows/release-build.yml

Lines changed: 25 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ jobs:
3333
apply-release-notes-template:
3434
runs-on: ubuntu-latest
3535
permissions:
36+
# `contents: write` is needed to modify a release.
37+
# Please note that this is an overly broad scope, but GitHub does not
38+
# currently provide a more fine-grained permission for release modification.
3639
contents: write
3740
steps:
3841
- uses: step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a # v2.13.1
@@ -59,6 +62,9 @@ jobs:
5962
flavor: [cpp, rust]
6063
runs-on: ubuntu-latest
6164
permissions:
65+
# `contents: write` is needed to modify a release.
66+
# Please note that this is an overly broad scope, but GitHub does not
67+
# currently provide a more fine-grained permission for release modification.
6268
contents: write
6369
needs: [build-push-test, apply-release-notes-template]
6470
env:
@@ -90,16 +96,6 @@ jobs:
9096
GH_TOKEN: ${{ github.token }}
9197
REPOSITORY_OWNER: ${{ github.repository_owner }}
9298
REPOSITORY_NAME: ${{ github.event.repository.name }}
93-
- uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
94-
with:
95-
pattern: documents
96-
- name: Upload documents to release
97-
run: |
98-
set -Eeuo pipefail
99-
gh release upload "${REF_NAME}" ./*.pdf
100-
env:
101-
GH_REPO: ${{ github.repository }}
102-
GH_TOKEN: ${{ github.token }}
10399
- name: Update package details in release
104100
run: |
105101
set -Eeuo pipefail
@@ -111,3 +107,22 @@ jobs:
111107
DIGEST: ${{ steps.inspect-manifest.outputs.digest }}
112108
GH_REPO: ${{ github.repository }}
113109
GH_TOKEN: ${{ github.token }}
110+
upload-documents:
111+
runs-on: ubuntu-latest
112+
permissions:
113+
# `contents: write` is needed to modify a release.
114+
# Please note that this is an overly broad scope, but GitHub does not
115+
# currently provide a more fine-grained permission for release modification.
116+
contents: write
117+
needs: [build-push-test]
118+
steps:
119+
- uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
120+
with:
121+
pattern: documents
122+
- name: Upload documents to release
123+
run: |
124+
set -Eeuo pipefail
125+
gh release upload "${REF_NAME}" ./*.pdf
126+
env:
127+
GH_REPO: ${{ github.repository }}
128+
GH_TOKEN: ${{ github.token }}

0 commit comments

Comments
 (0)