Skip to content

Commit 7bd23e7

Browse files
committed
ci: fix cancellation and metadata label
1 parent b6a1ffe commit 7bd23e7

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

.github/workflows/pr-conventional-title.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
env:
3434
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3535
- uses: marocchino/sticky-pull-request-comment@773744901bac0e8cbb5a0dc842800d45e9b2b405 # v2.9.4
36-
if: always() && steps.pr-title.outputs.error_message != null
36+
if: !cancelled() && steps.pr-title.outputs.error_message != null
3737
with:
3838
header: pr-title-lint-error
3939
message: |

.github/workflows/wc-acceptance-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
steps:
3131
- uses: step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a # v2.13.1
3232
with:
33-
# Playwright requires root privileges to install browsers
33+
disable-sudo: false # Playwright requires root privileges to install browsers
3434
egress-policy: audit
3535
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
3636
with:
@@ -90,7 +90,7 @@ jobs:
9090
GITHUB_TOTP_SECRET: ${{ secrets.TEST_GITHUB_TOTP_SECRET }}
9191
PLAYWRIGHT_JUNIT_OUTPUT_NAME: ${{ github.workspace }}/test-report-acceptance-${{ inputs.flavor }}.xml
9292
- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
93-
if: always()
93+
if: !cancelled()
9494
with:
9595
name: test-results-acceptance-${{ inputs.flavor }}
9696
path: |

.github/workflows/wc-build-push-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
checks: write
7474
pull-requests: write
7575
needs: [acceptance-test, integration-test]
76-
if: always()
76+
if: !cancelled()
7777
steps:
7878
- uses: step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a # v2.13.1
7979
with:

.github/workflows/wc-build-push.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ jobs:
120120
tags: ${{ needs.sanitize-image-name.outputs.fully-qualified-image-name }}
121121
labels: |
122122
${{ steps.metadata.outputs.labels }}
123-
${{ steps.devcontainer-metadata.outputs.metadata }}
123+
${{ steps.devcontainer-metadata.outputs.label }}
124124
annotations: ${{ steps.metadata.outputs.annotations }}
125125
sbom: true
126126
outputs: type=image,push-by-digest=true,name-canonical=true

.github/workflows/wc-integration-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
TEST_FILE: ${{ inputs.test-file }}
9292
RUNNER_ARCH: ${{ needs.determine-container.outputs.runner-arch }}
9393
- uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
94-
if: always()
94+
if: !cancelled()
9595
with:
9696
name: test-results-integration-${{ needs.sanitize-image-name.outputs.image-basename }}-${{ needs.determine-container.outputs.runner-arch }}
9797
path: test-report-*.xml

0 commit comments

Comments
 (0)