Skip to content

Commit 921e1df

Browse files
committed
ci: fix zizmore findings
1 parent 343f511 commit 921e1df

20 files changed

+29
-1
lines changed

.github/instructions/workflows.instructions.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,6 @@ When writing GitHub Action workflows, ensure that:
88

99
- Workflows that have a workflow_call trigger have their filename prefixed with `wc-`.
1010
- For all re-usable workflows, only the top-level workflow (workflows that are not called themselves by other workflows with workflow_call) has defaults and descriptions for inputs to avoid duplication.
11+
- All workflows and action definitions have a name that is descriptive and concise, using emoji where appropriate.
1112
- The sorting order for inputs, secrets, and outputs is alphabetical.
1213
- The sorting order of other keys is consistent across the repository.

.github/workflows/image-cleanup.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ on:
99
permissions: {}
1010

1111
jobs:
12-
delete-images:
12+
cleanup-images:
13+
name: 🧹 Clean Images
1314
runs-on: ubuntu-latest
1415
permissions:
1516
# dataaxiom/ghcr-cleanup-action needs packages write permission

.github/workflows/issue-cleanup.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ permissions: {}
99

1010
jobs:
1111
close-issues:
12+
name: ♻️ Close Stale Issues & PRs
1213
runs-on: ubuntu-latest
1314
permissions:
1415
issues: write

.github/workflows/linting-formatting.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ permissions:
1919

2020
jobs:
2121
linter:
22+
name: 🧹 Lint & Format
2223
runs-on: ubuntu-latest
2324
permissions:
2425
contents: read

.github/workflows/ossf-scorecard.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ permissions: read-all
1313

1414
jobs:
1515
ossf-scorecard:
16+
name: 🛡️ OpenSSF Scorecard
1617
runs-on: ubuntu-latest
1718
permissions:
1819
security-events: write

.github/workflows/pr-conventional-title.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ permissions: {}
1212

1313
jobs:
1414
validate-pr-title:
15+
name: ✅ Validate PR Title
1516
runs-on: ubuntu-latest
1617
permissions:
1718
pull-requests: write

.github/workflows/pr-image-cleanup.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ permissions: {}
99

1010
jobs:
1111
delete-images:
12+
name: 🗑️ Delete PR Images
1213
runs-on: ubuntu-latest
1314
permissions:
1415
packages: write
@@ -22,6 +23,7 @@ jobs:
2223
delete-tags: pr-${{ github.event.pull_request.number }}
2324
packages: amp-devcontainer,amp-devcontainer-cpp,amp-devcontainer-rust
2425
cleanup-cache:
26+
name: 🧹 Cleanup Cache
2527
runs-on: ubuntu-latest
2628
permissions:
2729
# actions: write permission is required to delete the cache

.github/workflows/pr-report.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ permissions: {}
99

1010
jobs:
1111
add-pr-report:
12+
name: 📊 Add PR Report
1213
permissions:
1314
contents: read
1415
checks: read

.github/workflows/release-build.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
acceptance-test-path: ${{ matrix.flavor == 'cpp' && 'test/cpp/features' || '' }}
4343
test-devcontainer-file: ${{ matrix.flavor == 'cpp' && '.devcontainer/cpp-test/devcontainer.json' || '' }}
4444
apply-release-notes-template:
45+
name: 📝 Apply Release Template
4546
runs-on: ubuntu-latest
4647
permissions:
4748
# `contents: write` is needed to modify a release.
@@ -68,6 +69,7 @@ jobs:
6869
GH_TOKEN: ${{ github.token }}
6970
REF_NAME: ${{ github.ref_name }}
7071
update-release-notes:
72+
name: Update Release Notes (🍨 ${{ matrix.flavor }})
7173
strategy:
7274
matrix:
7375
flavor: [cpp, rust]
@@ -119,6 +121,7 @@ jobs:
119121
GH_REPO: ${{ github.repository }}
120122
GH_TOKEN: ${{ github.token }}
121123
upload-documents:
124+
name: 📄 Upload Documents
122125
runs-on: ubuntu-latest
123126
permissions:
124127
# `contents: write` is needed to modify a release.

.github/workflows/release-please.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ permissions:
1414

1515
jobs:
1616
create-release:
17+
name: 🚀 Create Release
1718
runs-on: ubuntu-latest
1819
steps:
1920
- uses: step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a # v2.13.1

0 commit comments

Comments
 (0)