Skip to content

Commit 96c33db

Browse files
authored
docs: documentation update (#633)
* docs: update pull request template * docs: start merging requirements into feature files * docs: add dco to this project Signed-off-by: Ron <[email protected]> * chore: fix linter warnings Signed-off-by: Ron <[email protected]> * chore: revert DCO changes, isolate for a later update --------- Signed-off-by: Ron <[email protected]>
1 parent d7f811e commit 96c33db

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

.github/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ Before you submit your pull request consider the following guidelines:
149149
1. Commit your changes using a descriptive commit message.
150150

151151
```shell
152-
git commit --all
152+
git commit -s -m 'Awesome commit message'
153153
```
154154

155155
Note: the optional commit `-a` command-line option will automatically "add" and "rm" edited files.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
# Pull Request
1+
# :rocket: Hey, I have created a Pull Request
22

33
## Description of changes
44

55
<!-- Fill in a description of what this PR changes/introduces/fixes
66
Link to GitHub issues using keywords https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests when necessary
77
-->
88

9-
## Checklist
9+
## :heavy_check_mark: Checklist
1010

1111
<!-- We follow conventional commit-style PR titles and kebab-case branch names -->
1212

13-
- [ ] I have followed the contribution guidelines for this repository
13+
- [ ] I have followed the [contribution guidelines](https://github.com/philips-software/amp-devcontainer/blob/main/.github/CONTRIBUTING.md) for this repository
1414
- [ ] I have added tests for new behavior, and have not broken any existing tests
1515
- [ ] I have added or updated relevant documentation
1616
- [ ] I have verified that all added components are accounted for in the SBOM

README.md

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66

77
## Overview
88

9-
This repository contains [devcontainers](https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/introduction-to-dev-containers) tailored towards modern, embedded, C++ and Rust development.
9+
This repository contains [devcontainers](https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/introduction-to-dev-containers) tailored towards modern, embedded, software development.
10+
11+
The containers try to be as ":battery: batteries included" as possible without being overly opinionated, and are useable for both local development and continuous integration.
12+
13+
All containers are multi-platform, and can be used on x64 (x86-64) and arm64 hardware on an operating system that supports an [OCI](https://opencontainers.org/) compatible container engine. This includes Windows and Linux, and macOS on both Intel and Apple silicon.
1014

1115
## State
1216

@@ -16,7 +20,7 @@ This repository is under active development; see [pulse](https://github.com/phil
1620

1721
### Image variants
1822

19-
Two devcontainers are published towards the [GitHub Container Registry](https://ghcr.io/):
23+
The following devcontainers are published towards the [GitHub Container Registry](https://ghcr.io/):
2024

2125
- [amp-devcontainer-cpp](https://github.com/orgs/philips-software/packages/container/package/amp-devcontainer-cpp); the C++ container
2226
- [amp-devcontainer-rust](https://github.com/orgs/philips-software/packages/container/package/amp-devcontainer-rust); the Rust container
@@ -43,7 +47,7 @@ For embedded development and flashing and debugging [probe-rs](https://probe.rs/
4347

4448
### Visual Studio Code
4549

46-
Both containers can be used in Visual Studio Code or GitHub Codespaces without any additional configuration. All included tools are set-up and necessary plug-ins will be installed at container start. This behavior is implemented by appending devcontainer metadata to an image label according to the [specifications](https://containers.dev/implementors/reference/#labels). It is possible to override, amend or change the options following this [merge logic](https://containers.dev/implementors/spec/#merge-logic).
50+
Both containers can be used in Visual Studio Code or GitHub Codespaces without any additional configuration. All included tools are set-up and necessary plug-ins will be installed at container start. This behavior is implemented by appending devcontainer metadata to an image label according to these [specifications](https://containers.dev/implementors/reference/#labels). It is possible to override, amend or change the options following this [merge logic](https://containers.dev/implementors/spec/#merge-logic).
4751

4852
## Usage
4953

@@ -130,4 +134,4 @@ See [security](.github/SECURITY.md) for more information.
130134

131135
## Licenses
132136

133-
See [license](./LICENSE)
137+
See [license](./LICENSE).

test/cpp/features/static-dynamic-analysis.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
Feature: Analyze source code using static and dynamic analysis
22

3-
As a software craftsman
3+
As a software craftsperson
44
To maintain consistent, high-quality and bug-free code
5-
Source code needs to be statically and dynamically analyzed
5+
I want my source code to be statically and dynamically analyzed
66

77
@fixme
88
Scenario: Format source code according to a formatting style

0 commit comments

Comments
 (0)