ci: add requirement and change some naming

Author: rjaegers

.github/workflows/continuous-integration.yml

@@ -13,7 +13,7 @@ concurrency:
 permissions: {}
 
 jobs:
-  build-push-test-flavors:
+  build-push-test:
     name: Build, Push and Test (🍨 ${{ matrix.flavor }})
     strategy:
       matrix:
@@ -41,18 +41,20 @@ jobs:
       test-devcontainer-file: ${{ matrix.flavor == 'cpp' && '.devcontainer/cpp-test/devcontainer.json' || '' }}
 
   dependency-review:
-    needs: build-push-test-flavors
+    name: Review Dependencies
+    needs: build-push-test
     uses: ./.github/workflows/wc-dependency-review.yml
     permissions:
       contents: read
       pull-requests: write
 
   publish-test-results:
+    name: Publish Test Results
     runs-on: ubuntu-latest
     permissions:
       checks: write
       pull-requests: write
-    needs: build-push-test-flavors
+    needs: build-push-test
     if: ${{ !cancelled() }}
     steps:
       - uses: step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a # v2.13.1
@@ -68,6 +70,7 @@ jobs:
           files: test-report-*.xml
 
   generate-documents:
+    name: Generate Documents
     uses: ./.github/workflows/wc-document-generation.yml
     permissions:
       contents: read

.github/workflows/wc-sanitize-image-name.yml

@@ -16,18 +16,18 @@ on:
     outputs:
       image-basename:
         description: "The sanitized base name of the image (without registry or tag)"
-        value: ${{ jobs.sanitize-inputs.outputs.image-basename }}
+        value: ${{ jobs.sanitize.outputs.image-basename }}
       image-name:
         description: "The sanitized name of the image (without registry or tag)"
-        value: ${{ jobs.sanitize-inputs.outputs.image-name }}
+        value: ${{ jobs.sanitize.outputs.image-name }}
       fully-qualified-image-name:
         description: "The fully qualified name of the image including registry (but without tag)"
-        value: ${{ jobs.sanitize-inputs.outputs.fully-qualified-image-name }}
+        value: ${{ jobs.sanitize.outputs.fully-qualified-image-name }}
 
 permissions: {}
 
 jobs:
-  sanitize-inputs:
+  sanitize:
     runs-on: ${{ (startsWith(inputs.runner-labels, '[') && endsWith(inputs.runner-labels, ']')) && fromJson(inputs.runner-labels) || inputs.runner-labels }}
     outputs:
       image-basename: ${{ steps.sanitize-image-name.outputs.sanitized-basename }}

test/cpp/features/maintainability.feature

@@ -18,6 +18,12 @@ Feature: Maintainability
     This reduces the maintenance burden on users, as they do not need to manually track and apply updates.
     Automatic updates can also help ensure compatibility with other dependencies and tools, improving the overall stability and reliability of the development environment.
 
+  Rule: Re-usable build system
+    amp-devcontainer *SHOULD* provide re-usable building blocks to enable building, publishing and testing derived containers.
+
+    Providing re-usable building blocks for building, publishing and testing derived containers reduces duplication, and ensures consistent application of practices.
+    Derived containers (i.e. containers using amp-devcontainer as a base for further extension) should be able to build, push and test in the same way that amp-devcontainer does, without the need to duplicate the build system.
+
   Rule: Architectural decisions
     amp-devcontainer *SHOULD* document its architectural decisions.