fix: serialcommunication stop (#1061)

BarisTanyeri · web-flow · commit 2e785d33ad97 · 2026-01-13T14:23:48.000+01:00
* fix: update Stop method to clear data reception handler

* also fix the destructor
diff --git a/hal/interfaces/SerialCommunication.cpp b/hal/interfaces/SerialCommunication.cpp
@@ -19,7 +19,7 @@ namespace hal
 
     BufferedSerialCommunicationOnUnbuffered::~BufferedSerialCommunicationOnUnbuffered()
     {
-        delegate.ReceiveData([](infra::ConstByteRange) {});
+        delegate.ReceiveData(nullptr);
     }
 
     void BufferedSerialCommunicationOnUnbuffered::SendData(infra::ConstByteRange data, infra::Function<void()> actionOnCompletion)
@@ -40,7 +40,7 @@ namespace hal
 
     void BufferedSerialCommunicationOnUnbuffered::Stop(const infra::Function<void()>& onDone)
     {
-        delegate.ReceiveData([](infra::ConstByteRange) {});
+        delegate.ReceiveData(nullptr);
         scheduler.Schedule(onDone);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ namespace hal`
`19`	`19`
`20`	`20`	`BufferedSerialCommunicationOnUnbuffered::~BufferedSerialCommunicationOnUnbuffered()`
`21`	`21`	`{`
`22`		`- delegate.ReceiveData([](infra::ConstByteRange) {});`
	`22`	`+ delegate.ReceiveData(nullptr);`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`void BufferedSerialCommunicationOnUnbuffered::SendData(infra::ConstByteRange data, infra::Function<void()> actionOnCompletion)`
`@@ -40,7 +40,7 @@ namespace hal`
`40`	`40`
`41`	`41`	`void BufferedSerialCommunicationOnUnbuffered::Stop(const infra::Function<void()>& onDone)`
`42`	`42`	`{`
`43`		`- delegate.ReceiveData([](infra::ConstByteRange) {});`
	`43`	`+ delegate.ReceiveData(nullptr);`
`44`	`44`	`scheduler.Schedule(onDone);`
`45`	`45`	`}`
`46`	`46`