chore: give characteristic operation observer access to value handle (#1039)

Allow gatt char observer to access value handle

Author: heinwessels-philips

services/ble/GattServer.hpp

@@ -40,6 +40,7 @@ namespace services
 
         virtual AttAttribute::Handle ServiceHandle() const = 0;
         virtual AttAttribute::Handle CharacteristicHandle() const = 0;
+        virtual AttAttribute::Handle CharacteristicValueHandle() const = 0;
     };
 
     class GattServerCharacteristicOperations

services/ble/GattServerCharacteristicImpl.cpp

@@ -42,6 +42,11 @@ namespace services
         return handle;
     }
 
+    AttAttribute::Handle GattServerCharacteristicImpl::CharacteristicValueHandle() const
+    {
+        return valueHandle;
+    }
+
     void GattServerCharacteristicImpl::UpdateValue()
     {
         auto status = GattServerCharacteristicOperationsObserver::Subject().Update(*this, updateContext->data);

services/ble/GattServerCharacteristicImpl.hpp

@@ -22,6 +22,7 @@ namespace services
         // Implementation of GattServerCharacteristicOperationsObserver
         AttAttribute::Handle ServiceHandle() const override;
         AttAttribute::Handle CharacteristicHandle() const override;
+        AttAttribute::Handle CharacteristicValueHandle() const override;
 
     private:
         struct UpdateContext

services/ble/test/TestGattServer.cpp

@@ -22,9 +22,11 @@ TEST(GattServerTest, characteristic_implementation_handles_are_accesible)
     s.Handle() = 0xAB;
     services::GattServerCharacteristicImpl c{ s, uuid16, valueSize };
     c.Handle() = 0xCD;
+    c.ValueHandle() = 0xEF;
 
     EXPECT_EQ(0xAB, c.ServiceHandle());
     EXPECT_EQ(0xCD, c.CharacteristicHandle());
+    EXPECT_EQ(0xEF, c.CharacteristicValueHandle());
 }
 
 TEST(GattServerTest, characteristic_implementation_supports_different_uuid_lengths)

services/ble/test_doubles/GattServerMock.hpp

@@ -35,6 +35,7 @@ namespace services
     public:
         MOCK_METHOD(AttAttribute::Handle, ServiceHandle, (), (const));
         MOCK_METHOD(AttAttribute::Handle, CharacteristicHandle, (), (const));
+        MOCK_METHOD(AttAttribute::Handle, CharacteristicValueHandle, (), (const));
         MOCK_METHOD(void, Update, (infra::ConstByteRange data, infra::Function<void()> onDone));
     };
 }