shared key and secret are now optional

When not specified requests that need to be signed
will naturally fail

Author: loafoe

go.mod

@@ -6,8 +6,8 @@ require (
 	github.com/go-playground/validator/v10 v10.0.1
 	github.com/google/go-querystring v0.0.0-20170111101155-53e6ce116135
 	github.com/google/uuid v1.1.1
-	github.com/philips-software/go-hsdp-signer v1.1.0
-	github.com/stretchr/testify v1.4.0
+	github.com/philips-software/go-hsdp-signer v1.1.1-0.20200417110351-20ce3021c3ba
+	github.com/stretchr/testify v1.5.1
 	golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7
 )
 

go.sum

@@ -20,11 +20,15 @@ github.com/leodido/go-urn v1.2.0 h1:hpXL4XnriNwQ/ABnpepYM/1vCLWNDfUNts8dX3xTG6Y=
 github.com/leodido/go-urn v1.2.0/go.mod h1:+8+nEpDfqqsY+g338gtMEUOtuK+4dEMhiQEgxpxOKII=
 github.com/philips-software/go-hsdp-signer v1.1.0 h1:7fYij8q7uCr2AOzO9g3X45FNB9tddFPnvR5WNLo3pD4=
 github.com/philips-software/go-hsdp-signer v1.1.0/go.mod h1:mtq3D20YNxHQ8e318ci9hVb3DW5Hlo30D3abN7VeqLM=
+github.com/philips-software/go-hsdp-signer v1.1.1-0.20200417110351-20ce3021c3ba h1:w3T8KnsMtPVAMgl4Qf/znYUGzsM2kysQPyA5JNptCqQ=
+github.com/philips-software/go-hsdp-signer v1.1.1-0.20200417110351-20ce3021c3ba/go.mod h1:/QehZ/+Aks2t1TFpjhF/7ZSB8PJIIJHzLc03rOqwLw0=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
 github.com/stretchr/testify v1.4.0 h1:2E4SXV/wtOkTonXsotYi4li6zVWxYlZuYNCXe9XRJyk=
 github.com/stretchr/testify v1.4.0/go.mod h1:j7eGeouHqKxXV5pUuKE4zz7dFj8WfuZ+81PSLYec5m4=
+github.com/stretchr/testify v1.5.1 h1:nOGnQDM7FYENwehXlg/kFVnos3rEvtKTjRvOWSzb6H4=
+github.com/stretchr/testify v1.5.1/go.mod h1:5W2xD1RspED5o8YsWQXVCued0rvSQ+mT+I5cxcmMvtA=
 golang.org/x/text v0.3.2/go.mod h1:bEr9sfX3Q8Zfm5fL9x+3itogRgK3+ptLWKqgva+5dAk=
 golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7 h1:9zdDQZ7Thm29KFXgAX/+yaf3eVbP7djjWp/dXAppNCc=

iam/client.go

@@ -126,8 +126,8 @@ func newClient(httpClient *http.Client, config *Config) (*Client, error) {
 		return nil, err
 	}
 	signer, err := hsdpsigner.New(c.config.SharedKey, c.config.SecretKey)
-	if err != nil {
-		return nil, err
+	if err != nil { // Allow nil signer
+		signer = nil
 	}
 	if config.DebugLog != "" {
 		c.debugFile, err = os.OpenFile(config.DebugLog, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0600)
@@ -517,6 +517,9 @@ func newResponse(r *http.Response) *Response {
 
 // DoSigned performs a signed API request
 func (c *Client) DoSigned(req *http.Request, v interface{}) (*Response, error) {
+	if c.signer == nil {
+		return nil, ErrNoValidSignerAvailable
+	}
 	if err := c.signer.SignRequest(req); err != nil {
 		return nil, err
 	}

iam/client_test.go

@@ -34,17 +34,20 @@ func setup(t *testing.T) func() {
 	serverIDM = httptest.NewServer(muxIDM)
 	sharedKey := "SharedKey"
 	secretKey := "SecretKey"
+	var err error
 
-	signerHSDP, _ = signer.New(sharedKey, secretKey)
+	signerHSDP, err = signer.New(sharedKey, secretKey)
+	assert.Nil(t, err)
 
-	client, _ = NewClient(nil, &Config{
+	client, err = NewClient(nil, &Config{
 		OAuth2ClientID: "TestClient",
 		OAuth2Secret:   "Secret",
 		SharedKey:      sharedKey,
 		SecretKey:      secretKey,
 		IAMURL:         serverIAM.URL,
 		IDMURL:         serverIDM.URL,
 	})
+	assert.Nil(t, err)
 
 	token = "44d20214-7879-4e35-923d-f9d4e01c9746"
 	token2 := "55d20214-7879-4e35-923d-f9d4e01c9746"
@@ -78,6 +81,27 @@ func setup(t *testing.T) func() {
 	}
 }
 
+func TestWithMissingSigner(t *testing.T) {
+	muxIAM = http.NewServeMux()
+	serverIAM = httptest.NewServer(muxIAM)
+	muxIDM = http.NewServeMux()
+	serverIDM = httptest.NewServer(muxIDM)
+	var err error
+
+	client, err = NewClient(nil, &Config{
+		OAuth2ClientID: "TestClient",
+		OAuth2Secret:   "Secret",
+		IAMURL:         serverIAM.URL,
+		IDMURL:         serverIDM.URL,
+	})
+	assert.Nil(t, err)
+	assert.NotNil(t, client)
+	assert.Nil(t, client.signer)
+	resp, err := client.DoSigned(&http.Request{}, nil)
+	assert.Nil(t, resp)
+	assert.Equal(t, ErrNoValidSignerAvailable, err)
+}
+
 func TestLogin(t *testing.T) {
 	teardown := setup(t)
 	defer teardown()

iam/errors.go

@@ -23,6 +23,7 @@ var (
 	ErrMissingEtagInformation         = errors.New("missing etag information")
 	ErrMissingRefreshToken            = errors.New("missing refresh token")
 	ErrNotAuthorized                  = errors.New("not authorized")
+	ErrNoValidSignerAvailable         = errors.New("no valid HSDP signer available")
 )
 
 type UserError struct {