Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Commit f9ef8a9

Browse files
committed
Change Cartel client method visibility
1 parent 09e8d5d commit f9ef8a9

18 files changed

+41
-41
lines changed

cartel/add_security_groups.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ func (c *Client) AddSecurityGroups(instances []string, groups []string) (*Securi
2121
body.NameTag = instances
2222
body.SecurityGroup = groups
2323

24-
req, err := c.NewRequest("POST", "v3/api/add_security_groups", &body, nil)
24+
req, err := c.newRequest("POST", "v3/api/add_security_groups", &body, nil)
2525
if err != nil {
2626
return nil, nil, err
2727
}
2828
var responseBody SecurityGroupsResponse
29-
resp, err := c.Do(req, &responseBody)
29+
resp, err := c.do(req, &responseBody)
3030

3131
return &responseBody, resp, err
3232
}

cartel/add_tags.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ func (c *Client) AddTags(instances []string, tags map[string]string) (*AddTagRes
1515
body.NameTag = instances
1616
body.Tags = tags
1717

18-
req, err := c.NewRequest("POST", "v3/api/add_tags", &body, nil)
18+
req, err := c.newRequest("POST", "v3/api/add_tags", &body, nil)
1919
if err != nil {
2020
return nil, nil, err
2121
}
2222
var responseBody AddTagResponse
23-
resp, err := c.Do(req, &responseBody)
23+
resp, err := c.do(req, &responseBody)
2424

2525
return &responseBody, resp, err
2626

cartel/add_user_groups.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ func (c *Client) AddUserGroups(instances []string, groups []string) (*UserGroups
1818
body.NameTag = instances
1919
body.LDAPGroups = groups
2020

21-
req, err := c.NewRequest("POST", "v3/api/add_ldap_group", &body, nil)
21+
req, err := c.newRequest("POST", "v3/api/add_ldap_group", &body, nil)
2222
if err != nil {
2323
return nil, nil, err
2424
}
2525
var responseBody UserGroupsResponse
26-
resp, err := c.Do(req, &responseBody)
26+
resp, err := c.do(req, &responseBody)
2727

2828
return &responseBody, resp, err
2929
}

cartel/all_instances.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ package cartel
33
func (c *Client) GetAllInstances() (*[]InstanceDetails, *Response, error) {
44
var body RequestBody
55

6-
req, err := c.NewRequest("POST", "v3/api/get_all_instances", &body, nil)
6+
req, err := c.newRequest("POST", "v3/api/get_all_instances", &body, nil)
77
if err != nil {
88
return nil, nil, err
99
}
1010

1111
var responseBody []InstanceDetails
1212

13-
resp, err := c.Do(req, &responseBody)
13+
resp, err := c.do(req, &responseBody)
1414

1515
return &responseBody, resp, err
1616
}

cartel/client.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,12 @@ func configDebug(cartel *Client) {
143143
}
144144
}
145145

146-
// Do sends an API request and returns the API response. The API response is
146+
// do sends an API request and returns the API response. The API response is
147147
// JSON decoded and stored in the value pointed to by v, or returned as an
148148
// error if an API error has occurred. If v implements the io.Writer
149149
// interface, the raw response body will be written to v, without attempting to
150150
// first decode it.
151-
func (c *Client) Do(req *http.Request, v interface{}) (*Response, error) {
151+
func (c *Client) do(req *http.Request, v interface{}) (*Response, error) {
152152
if c.debugFile != nil {
153153
dumped, _ := httputil.DumpRequest(req, true)
154154
fmt.Fprintf(c.debugFile, "REQUEST: %s\n", string(dumped))
@@ -179,25 +179,25 @@ func (c *Client) Do(req *http.Request, v interface{}) (*Response, error) {
179179
if err != nil {
180180
return response, err
181181
}
182-
err = CheckResponse(resp)
182+
err = checkResponse(resp)
183183
return response, err
184184
}
185185

186-
// CheckResponse checks the API response for errors, and returns them if present.
187-
func CheckResponse(r *http.Response) error {
186+
// checkResponse checks the API response for errors, and returns them if present.
187+
func checkResponse(r *http.Response) error {
188188
switch r.StatusCode {
189189
case 200, 201, 202, 204, 304:
190190
return nil
191191
}
192192
return ErrNonHttp20xResponse
193193
}
194194

195-
// NewRequest creates an API request. A relative URL path can be provided in
195+
// newRequest creates an API request. A relative URL path can be provided in
196196
// urlStr, in which case it is resolved relative to the base URL of the Client.
197197
// Relative URL paths should always be specified without a preceding slash. If
198198
// specified, the value pointed to by body is JSON encoded and included as the
199199
// request body.
200-
func (c *Client) NewRequest(method, path string, opt *RequestBody, options []OptionFunc) (*http.Request, error) {
200+
func (c *Client) newRequest(method, path string, opt *RequestBody, options []OptionFunc) (*http.Request, error) {
201201
u := *c.baseURL
202202
u.Opaque = c.baseURL.Path + path
203203

cartel/create.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ func (c *Client) Create(tagName string, opts ...RequestOptionFunc) (*CreateRespo
4747
}
4848
var responseBody CreateResponse
4949

50-
req, err := c.NewRequest("POST", "v3/api/create", &body, nil)
50+
req, err := c.newRequest("POST", "v3/api/create", &body, nil)
5151
if err != nil {
5252
return nil, nil, err
5353
}
54-
resp, err := c.Do(req, &responseBody)
54+
resp, err := c.do(req, &responseBody)
5555
return &responseBody, resp, err
5656
}

cartel/deployment_state.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ func (c *Client) GetDeploymentState(nameTag string) (string, *Response, error) {
44
var body RequestBody
55
body.NameTag = []string{nameTag}
66

7-
req, err := c.NewRequest("POST", "v3/api/deployment_status", &body, nil)
7+
req, err := c.newRequest("POST", "v3/api/deployment_status", &body, nil)
88
if err != nil {
99
return "fatal_error", nil, err
1010
}
1111
var responseBody map[string]interface{}
12-
resp, err := c.Do(req, &responseBody)
12+
resp, err := c.do(req, &responseBody)
1313
if err != nil {
1414
return "unknown_instance", resp, err
1515
}

cartel/destroy.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ func (c *Client) Destroy(tagName string) (*DestroyResponse, *Response, error) {
1919
var body RequestBody
2020
body.NameTag = []string{tagName}
2121

22-
req, err := c.NewRequest("POST", "v3/api/destroy", &body, nil)
22+
req, err := c.newRequest("POST", "v3/api/destroy", &body, nil)
2323
if err != nil {
2424
return nil, nil, err
2525
}
2626
var responseBody DestroyResponse
2727

28-
resp, err := c.Do(req, &responseBody)
28+
resp, err := c.do(req, &responseBody)
2929
if err != nil {
3030
return nil, resp, err
3131
}

cartel/details.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,14 +50,14 @@ func (c *Client) GetDetailsMulti(tags ...string) (*DetailsResponse, *Response, e
5050
var body RequestBody
5151
body.NameTag = tags
5252

53-
req, err := c.NewRequest("POST", "v3/api/instance_details", &body, nil)
53+
req, err := c.newRequest("POST", "v3/api/instance_details", &body, nil)
5454
if err != nil {
5555
return nil, nil, err
5656
}
5757

5858
var detailResponse []map[string]InstanceDetails
5959

60-
resp, err := c.Do(req, &detailResponse)
60+
resp, err := c.do(req, &detailResponse)
6161
response := make(DetailsResponse, len(detailResponse))
6262
for _, r := range detailResponse {
6363
for k, v := range r {

cartel/remove_security_groups.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ func (c *Client) RemoveSecurityGroups(instances []string, groups []string) (*Sec
55
body.NameTag = instances
66
body.SecurityGroup = groups
77

8-
req, err := c.NewRequest("POST", "v3/api/remove_security_groups", &body, nil)
8+
req, err := c.newRequest("POST", "v3/api/remove_security_groups", &body, nil)
99
if err != nil {
1010
return nil, nil, err
1111
}
1212
var responseBody SecurityGroupsResponse
13-
resp, err := c.Do(req, &responseBody)
13+
resp, err := c.do(req, &responseBody)
1414

1515
return &responseBody, resp, err
1616
}

0 commit comments

Comments
 (0)