Fix linter issues

Signed-off-by: Andy Lo-A-Foe <[email protected]>

Author: loafoe

.gitignore

@@ -11,3 +11,4 @@ profile_file.out
 config.yml
 /build/
 /.scannerwork/
+env.sh

handlers/ironio_test.go

@@ -40,7 +40,7 @@ func TestIronIOHandler(t *testing.T) {
 }
 
 func TestIronInvalidToken(t *testing.T) {
-	os.Setenv("DEBUG", "true")
+	_ = os.Setenv("DEBUG", "true")
 
 	e, teardown := setup(t)
 	defer teardown()

handlers/syslog.go

@@ -22,7 +22,7 @@ type SyslogHandler struct {
 
 func NewSyslogHandler(token string, pusher queue.Queue) (*SyslogHandler, error) {
 	if token == "" {
-		return nil, fmt.Errorf("Missing TOKEN value")
+		return nil, fmt.Errorf("missing TOKEN value")
 	}
 	handler := &SyslogHandler{}
 	handler.token = token

shared/plugin_manager.go

@@ -104,7 +104,7 @@ func (m *PluginManager) Discover() error {
 		paths, err := plugin.Discover(PluginGlob, dir)
 		if err != nil {
 			return fmt.Errorf(
-				"Error discovering plugins in %s: %s", dir, err)
+				"error discovering plugins in %s: %s", dir, err)
 		}
 
 		for _, path := range paths {
@@ -158,7 +158,7 @@ func (m *PluginManager) LoadAll() error {
 				merrLock.Lock()
 				defer merrLock.Unlock()
 				merr = multierror.Append(merr, fmt.Errorf(
-					"Error loading plugin %s: %s",
+					"error loading plugin %s: %s",
 					plugin.Path, err))
 			}
 		}(plugin)

shared/proto/resource.pb_test.go

@@ -152,7 +152,9 @@ func TestFilter(t *testing.T) {
 			Message: "foo",
 		},
 	}
-	defer conn.Close()
+	defer func() {
+		_ = conn.Close()
+	}()
 	client := proto.NewFilterClient(conn)
 	resp, err := client.Filter(ctx, &proto.FilterRequest{
 		Resource: resource,