Addressing some tect debt in tests.

Author: jzonthemtn

phileas-core/src/test/java/ai/philterd/test/phileas/services/EndToEndTestsHelper.java

@@ -192,7 +192,7 @@ public static Policy getPdfPolicy(String policyName) throws IOException {
         zipCodeFilterStrategy.setTruncateDigits(2);
 
         ZipCode zipCode = new ZipCode();
-        zipCode.setZipCodeFilterStrategies(Arrays.asList(zipCodeFilterStrategy));
+        zipCode.setZipCodeFilterStrategies(List.of(zipCodeFilterStrategy));
 
         CustomDictionaryFilterStrategy customDictionaryFilterStrategy = new CustomDictionaryFilterStrategy();
         customDictionaryFilterStrategy.setStrategy("REDACT");
@@ -220,7 +220,7 @@ public static Policy getPolicyJustCreditCardNotInUnixTimestamps(String policyNam
 
         CreditCard creditCard = new CreditCard();
         creditCard.setIgnoreWhenInUnixTimestamp(true);
-        creditCard.setCreditCardFilterStrategies(Arrays.asList(creditCardFilterStrategy));
+        creditCard.setCreditCardFilterStrategies(List.of(creditCardFilterStrategy));
 
         Identifiers identifiers = new Identifiers();
         identifiers.setCreditCard(creditCard);
@@ -242,7 +242,7 @@ public static Policy getPolicyJustCreditCard(String policyName) {
         CreditCardFilterStrategy creditCardFilterStrategy = new CreditCardFilterStrategy();
 
         CreditCard creditCard = new CreditCard();
-        creditCard.setCreditCardFilterStrategies(Arrays.asList(creditCardFilterStrategy));
+        creditCard.setCreditCardFilterStrategies(List.of(creditCardFilterStrategy));
 
         Identifiers identifiers = new Identifiers();
         identifiers.setCreditCard(creditCard);
@@ -406,13 +406,13 @@ public static Policy getPolicy(String policyName) throws IOException, URISyntaxE
     public static Policy getPolicyJustIdentifier(String policyName) {
 
         Identifier identifier1 = new Identifier();
-        identifier1.setIdentifierFilterStrategies(Arrays.asList(new IdentifierFilterStrategy()));
+        identifier1.setIdentifierFilterStrategies(List.of(new IdentifierFilterStrategy()));
         identifier1.setPattern("\\b\\d{3,8}\\b");
         identifier1.setCaseSensitive(false);
 
         Identifiers identifiers = new Identifiers();
 
-        identifiers.setIdentifiers(Arrays.asList(identifier1));
+        identifiers.setIdentifiers(List.of(identifier1));
 
         Policy policy = new Policy();
         policy.setName(policyName);

phileas-core/src/test/java/ai/philterd/test/phileas/services/filters/DateFilterTest.java

@@ -38,13 +38,12 @@ public class DateFilterTest extends AbstractFilterTest {
 
     private FilterConfiguration buildFilterConfiguration() {
 
-        final FilterConfiguration filterConfiguration = new FilterConfiguration.FilterConfigurationBuilder()
+        return new FilterConfiguration.FilterConfigurationBuilder()
                 .withStrategies(List.of(new DateFilterStrategy()))
                 .withAnonymizationService(new DateAnonymizationService(new InMemoryCache()))
                 .withAlertService(alertService)
                 .build();
 
-        return filterConfiguration;
     }
 
     @Test
@@ -416,7 +415,7 @@ public void filterDate34() throws Exception {
         dateFilterStrategy.setShiftYears(3);
 
         final FilterConfiguration filterConfiguration = new FilterConfiguration.FilterConfigurationBuilder()
-                .withStrategies(Arrays.asList(dateFilterStrategy))
+                .withStrategies(List.of(dateFilterStrategy))
                 .withAnonymizationService(new DateAnonymizationService(new InMemoryCache()))
                 .withAlertService(alertService)
                 .build();

phileas-core/src/test/java/ai/philterd/test/phileas/services/postfilters/IgnoredPatternsFilterTest.java

@@ -37,7 +37,7 @@ public void ignored1() {
         ignoredPattern.setName("example-id");
 
         final Policy policy = new Policy();
-        policy.setIgnoredPatterns(Arrays.asList(ignoredPattern));
+        policy.setIgnoredPatterns(List.of(ignoredPattern));
 
         final List<Span> spans = new LinkedList<>();
         spans.add(Span.make(6, 10, FilterType.IDENTIFIER, "context", "docid", 0.80, "AB01", "*****",  "", false, true, new String[0], 0));
@@ -57,12 +57,12 @@ public void notIgnored1() {
         ignoredPattern.setName("example-id");
 
         final Policy policy = new Policy();
-        policy.setIgnoredPatterns(Arrays.asList(ignoredPattern));
+        policy.setIgnoredPatterns(List.of(ignoredPattern));
 
         final List<Span> spans = new LinkedList<>();
         spans.add(Span.make(6, 10, FilterType.IDENTIFIER, "context", "docid", 0.80, "Ab01", "*****",  "", false, true, new String[0], 0));
 
-        final IgnoredPatternsFilter ignoredPatternsFilter = new IgnoredPatternsFilter(Arrays.asList(ignoredPattern));
+        final IgnoredPatternsFilter ignoredPatternsFilter = new IgnoredPatternsFilter(List.of(ignoredPattern));
         final List<Span> filteredSpans = ignoredPatternsFilter.filter("ID is Ab01.", spans);
 
         Assertions.assertEquals(1, filteredSpans.size());

phileas-model/src/test/java/ai/philterd/test/phileas/model/conditions/FilterConditionGrammarTest.java

@@ -31,9 +31,7 @@ public class FilterConditionGrammarTest {
     @Test
     public void testPopulationWithAND() {
 
-        final ParserListener parserListener = new ParserListener();
-
-        final List<ParsedCondition> conditions = parserListener.getTerminals("population < 2500 and population > 10000");
+        final List<ParsedCondition> conditions = ParserListener.getTerminals("population < 2500 and population > 10000");
 
         Assertions.assertEquals(2, conditions.size());
 
@@ -54,9 +52,7 @@ public void testPopulationWithAND() {
     @Test
     public void testPopulation() {
 
-        final ParserListener parserListener = new ParserListener();
-
-        final List<ParsedCondition> conditions = parserListener.getTerminals("population < 2500");
+        final List<ParsedCondition> conditions = ParserListener.getTerminals("population < 2500");
 
         final ParsedCondition parsedCondition = conditions.get(0);
 
@@ -69,9 +65,7 @@ public void testPopulation() {
     @Test
     public void testToken() {
 
-        final ParserListener parserListener = new ParserListener();
-
-        final List<ParsedCondition> conditions = parserListener.getTerminals("token == \"test\"");
+        final List<ParsedCondition> conditions = ParserListener.getTerminals("token == \"test\"");
 
         ParsedCondition parsedCondition = conditions.get(0);
 
@@ -84,9 +78,7 @@ public void testToken() {
     @Test
     public void testNerConditions1() {
 
-        final ParserListener parserListener = new ParserListener();
-
-        final List<ParsedCondition> conditions = parserListener.getTerminals("confidence != 0.5 and type != LOC");
+        final List<ParsedCondition> conditions = ParserListener.getTerminals("confidence != 0.5 and type != LOC");
 
         Assertions.assertEquals(2, conditions.size());
 
@@ -107,9 +99,7 @@ public void testNerConditions1() {
     @Test
     public void testNerConditions2() {
 
-        final ParserListener parserListener = new ParserListener();
-
-        final List<ParsedCondition> conditions = parserListener.getTerminals("confidence < 0.4 and type == PER");
+        final List<ParsedCondition> conditions = ParserListener.getTerminals("confidence < 0.4 and type == PER");
 
         Assertions.assertEquals(2, conditions.size());