Skip to content

Commit 2366d77

Browse files
m-maryiaChromium LUCI CQ
authored andcommitted
Fix CollectMetrics refactoring
Bug: 369503318 Change-Id: I283f2aac2420004e71f3609a342f0674fb9dd4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7063291 Reviewed-by: Florian Leimgruber <[email protected]> Commit-Queue: Maryia Mankevich <[email protected]> Cr-Commit-Position: refs/heads/main@{#1532365}
1 parent e562491 commit 2366d77

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

components/autofill/core/browser/form_import/addresses/autofill_profile_import_process.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ void ProfileImportProcess::CollectMetrics(
620620
// For an import process that involves prompting the user, record the
621621
// decision.
622622
if (import_type_ == AutofillProfileImportType::kNewProfile) {
623-
LogNewProfileMetrics();
623+
LogNewProfileMetrics(existing_profiles);
624624
LogUkmMetrics(ukm_recorder, existing_profiles, num_edited_fields);
625625
} else if (import_type_ ==
626626
AutofillProfileImportType::kHomeWorkNameEmailMerge) {
@@ -668,9 +668,10 @@ void ProfileImportProcess::LogUkmMetrics(
668668
existing_profiles, app_locale_);
669669
}
670670

671-
void ProfileImportProcess::LogNewProfileMetrics() const {
671+
void ProfileImportProcess::LogNewProfileMetrics(
672+
const std::vector<const AutofillProfile*>& existing_profiles) const {
672673
autofill_metrics::LogNewProfileImportDecision(
673-
user_decision_, import_metadata_, {},
674+
user_decision_, import_metadata_, existing_profiles,
674675
UserAccepted() ? *confirmed_import_candidate_ : *import_candidate_,
675676
app_locale_);
676677
if (UserAccepted()) {

components/autofill/core/browser/form_import/addresses/autofill_profile_import_process.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,8 @@ class ProfileImportProcess {
318318
int num_edited_fields = 0) const;
319319

320320
// Records new profile import metrics after the import was applied.
321-
void LogNewProfileMetrics() const;
321+
void LogNewProfileMetrics(
322+
const std::vector<const AutofillProfile*>& existing_profiles) const;
322323

323324
// Records confirmable profile update metrics after the import was applied.
324325
void LogConfirmableProfileUpdateMetrics(

0 commit comments

Comments
 (0)