Skip to content

Commit c419d81

Browse files
Jeffrey YuChromium LUCI CQ
authored andcommitted
Add reserve statement for vectors when size is known in advance.
Change-Id: I26559a05037123845603c39b506d091be022b9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7049945 Commit-Queue: Jeffrey Yu <[email protected]> Reviewed-by: Colin Blundell <[email protected]> Reviewed-by: Rushan Suleymanov <[email protected]> Cr-Commit-Position: refs/heads/main@{#1532389}
1 parent be1bb74 commit c419d81

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

components/sync/android/sync_service_android_bridge.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,7 @@ DataType IntToDataTypeChecked(int type) {
5252

5353
ScopedJavaLocalRef<jintArray> DataTypeSetToJavaIntArray(JNIEnv* env,
5454
DataTypeSet types) {
55-
std::vector<int> type_vector;
56-
for (DataType type : types) {
57-
type_vector.push_back(type);
58-
}
55+
std::vector<int> type_vector(types.begin(), types.end());
5956
return base::android::ToJavaIntArray(env, type_vector);
6057
}
6158

@@ -74,6 +71,7 @@ ScopedJavaLocalRef<jintArray> UserSelectableTypeSetToJavaIntArray(
7471
JNIEnv* env,
7572
UserSelectableTypeSet types) {
7673
std::vector<int> type_vector;
74+
type_vector.reserve(types.size());
7775
for (UserSelectableType type : types) {
7876
type_vector.push_back(static_cast<int>(type));
7977
}
@@ -100,7 +98,9 @@ void NativeGetLocalDataDescriptionsCallback(
10098
const base::android::ScopedJavaGlobalRef<jobject>& callback,
10199
std::map<DataType, LocalDataDescription> localDataDescription) {
102100
std::vector<int> data_types;
101+
data_types.reserve(localDataDescription.size());
103102
std::vector<LocalDataDescription> local_data_descriptions;
103+
local_data_descriptions.reserve(localDataDescription.size());
104104
for (const auto& [data_type, description] : localDataDescription) {
105105
data_types.push_back(data_type);
106106
local_data_descriptions.push_back(description);

0 commit comments

Comments
 (0)