Skip to content

Commit f29c2a9

Browse files
MostafaAboalkasimChromium LUCI CQ
authored andcommitted
Enable local overrides at the start of some tests.
That change prevents indexing Local Overrides when they are disabled, which caused these test to fail since it depends on them being available. Bug: 40752084 Change-Id: Ie750561b3b93c44aa14dee85843ea213cdad3178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7060310 Reviewed-by: Simon Zünd <[email protected]> Reviewed-by: Paul Irish <[email protected]> Commit-Queue: Paul Irish <[email protected]> Cr-Commit-Position: refs/heads/main@{#1532395}
1 parent 70605ea commit f29c2a9

File tree

4 files changed

+7
-0
lines changed

4 files changed

+7
-0
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,6 +1095,7 @@ Mohraiel Matta <[email protected]>
10951095
Moiseanu Rares-Marian <[email protected]>
10961096
Momoka Yamamoto <[email protected]>
10971097
Momoko Hattori <[email protected]>
1098+
Mostafa Aboalkasim <[email protected]>
10981099
Mostafa Sedaghat joo <[email protected]>
10991100
Mrunal Kapade <[email protected]>
11001101
Muhammad Mahad <[email protected]>

third_party/blink/web_tests/http/tests/devtools/persistence/persistence-search-across-all-files.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,13 @@ import {TestRunner} from 'test_runner';
66
import {SourcesTestRunner} from 'sources_test_runner';
77
import {BindingsTestRunner} from 'bindings_test_runner';
88

9+
import * as Common from 'devtools/core/common/common.js';
910
import * as Workspace from 'devtools/models/workspace/workspace.js';
1011
import * as SourcesModule from 'devtools/panels/sources/sources.js';
1112
import * as Persistence from 'devtools/models/persistence/persistence.js';
1213

1314
(async function() {
15+
Common.Settings.Settings.instance().moduleSetting('persistence-network-overrides-enabled').set(true);
1416
TestRunner.addResult(`Verify that search across all files omits filesystem uiSourceCodes with binding to network.\n`);
1517
await TestRunner.addScriptTag('resources/foo.js');
1618

third_party/blink/web_tests/http/tests/devtools/search/sources-search-scope-in-files.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,13 @@ import {TestRunner} from 'test_runner';
66
import {BindingsTestRunner} from 'bindings_test_runner';
77
import {SourcesTestRunner} from 'sources_test_runner';
88

9+
import * as Common from 'devtools/core/common/common.js';
910
import * as Workspace from 'devtools/models/workspace/workspace.js';
1011
import * as SourcesModule from 'devtools/panels/sources/sources.js';
1112
import * as Persistence from 'devtools/models/persistence/persistence.js';
1213

1314
(async function() {
15+
Common.Settings.Settings.instance().moduleSetting('persistence-network-overrides-enabled').set(true);
1416
TestRunner.addResult(`Tests that ScriptSearchScope performs search across all sources correctly.\n`);
1517
await TestRunner.showPanel('sources');
1618

third_party/blink/web_tests/http/tests/devtools/search/sources-search-scope-many-projects.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,13 @@ import {TestRunner} from 'test_runner';
66
import {BindingsTestRunner} from 'bindings_test_runner';
77
import {SourcesTestRunner} from 'sources_test_runner';
88

9+
import * as Common from 'devtools/core/common/common.js';
910
import * as Workspace from 'devtools/models/workspace/workspace.js';
1011
import * as SourcesModule from 'devtools/panels/sources/sources.js';
1112
import * as Persistence from 'devtools/models/persistence/persistence.js';
1213

1314
(async function() {
15+
Common.Settings.Settings.instance().moduleSetting('persistence-network-overrides-enabled').set(true);
1416
TestRunner.addResult(`Tests that ScriptSearchScope sorts network and dirty results correctly.\n`);
1517
await TestRunner.showPanel('sources');
1618

0 commit comments

Comments
 (0)