Skip to content

Commit 51c585d

Browse files
andreaslucaphimage
authored andcommitted
Fix xcode warning (#18)
* Remove Swift 4 warning * Remove warning in latest Xcode version (9.4.1)
1 parent d5381d5 commit 51c585d

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

CallbackURLKit.xcodeproj/project.pbxproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@
241241
C4A8D5071C37D84A00DB3306 /* Project object */ = {
242242
isa = PBXProject;
243243
attributes = {
244-
LastUpgradeCheck = 0900;
244+
LastUpgradeCheck = 0940;
245245
ORGANIZATIONNAME = phimage;
246246
TargetAttributes = {
247247
C418B1D91C386C160097FDD9 = {
@@ -402,12 +402,14 @@
402402
CLANG_WARN_BOOL_CONVERSION = YES;
403403
CLANG_WARN_COMMA = YES;
404404
CLANG_WARN_CONSTANT_CONVERSION = YES;
405+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
405406
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
406407
CLANG_WARN_EMPTY_BODY = YES;
407408
CLANG_WARN_ENUM_CONVERSION = YES;
408409
CLANG_WARN_INFINITE_RECURSION = YES;
409410
CLANG_WARN_INT_CONVERSION = YES;
410411
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
412+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
411413
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
412414
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
413415
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
@@ -459,12 +461,14 @@
459461
CLANG_WARN_BOOL_CONVERSION = YES;
460462
CLANG_WARN_COMMA = YES;
461463
CLANG_WARN_CONSTANT_CONVERSION = YES;
464+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
462465
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
463466
CLANG_WARN_EMPTY_BODY = YES;
464467
CLANG_WARN_ENUM_CONVERSION = YES;
465468
CLANG_WARN_INFINITE_RECURSION = YES;
466469
CLANG_WARN_INT_CONVERSION = YES;
467470
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
471+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
468472
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
469473
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
470474
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;

CallbackURLKit.xcodeproj/xcshareddata/xcschemes/CallbackURLKit.xcscheme

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0900"
3+
LastUpgradeVersion = "0940"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"
@@ -26,7 +26,6 @@
2626
buildConfiguration = "Debug"
2727
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2828
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
29-
language = ""
3029
shouldUseLaunchSchemeArgsEnv = "YES">
3130
<Testables>
3231
</Testables>
@@ -37,7 +36,6 @@
3736
buildConfiguration = "Debug"
3837
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
3938
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
40-
language = ""
4139
launchStyle = "0"
4240
useCustomWorkingDirectory = "NO"
4341
ignoresPersistentStateOnLaunch = "NO"

CallbackURLKit.xcodeproj/xcshareddata/xcschemes/CallbackURLKitOSX.xcscheme

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0900"
3+
LastUpgradeVersion = "0940"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"
@@ -26,7 +26,6 @@
2626
buildConfiguration = "Debug"
2727
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
2828
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
29-
language = ""
3029
shouldUseLaunchSchemeArgsEnv = "YES">
3130
<Testables>
3231
</Testables>
@@ -37,7 +36,6 @@
3736
buildConfiguration = "Debug"
3837
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
3938
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
40-
language = ""
4139
launchStyle = "0"
4240
useCustomWorkingDirectory = "NO"
4341
ignoresPersistentStateOnLaunch = "NO"

Sources/Manager.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ open class Manager {
7373
}
7474
let path = url.path
7575

76-
let action = String(path.characters.dropFirst()) // remove /
76+
let action = String(path.dropFirst()) // remove /
7777

7878
let parameters = url.query?.toQueryDictionary ?? [:]
7979
let actionParameters = Manager.action(parameters: parameters)

0 commit comments

Comments
 (0)