Fix travis, change minimal version and open(url function on iOS

Author: e-marchand

.travis.yml

@@ -1,16 +1,16 @@
 language: objective-c
-osx_image: xcode10
+osx_image: xcode10.2
 env:
   global:
     - LC_CTYPE=en_US.UTF-8
     - LANG=en_US.UTF-8
     - PROJECT=CallbackURLKit.xcodeproj
     - IOS_FRAMEWORK_SCHEME="CallbackURLKit"
     - MACOS_FRAMEWORK_SCHEME="CallbackURLKitOSX"
-    - IOS_SDK=iphonesimulator12.0
+    - IOS_SDK=iphonesimulator12.2
     - MACOS_SDK=macosx10.14
   matrix:
-    - DESTINATION="OS=12.0,name=iPhone 8" SCHEME="$IOS_FRAMEWORK_SCHEME" SDK="$IOS_SDK" RUN_TESTS="NO"
+    - DESTINATION="OS=12.2,name=iPhone 8" SCHEME="$IOS_FRAMEWORK_SCHEME" SDK="$IOS_SDK" RUN_TESTS="NO"
     - DESTINATION="arch=x86_64" SCHEME="$MACOS_FRAMEWORK_SCHEME" SDK="$MACOS_SDK" RUN_TESTS="NO"
 before_install:
   - gem install xcpretty --no-rdoc --no-ri --no-document --quiet

CallbackURLKit.podspec

@@ -13,9 +13,9 @@ Pod::Spec.new do |s|
   s.author             = { "phimage" => "[email protected]" }
 
   # ――― Platform Specifics ――――――――――――――――――――――――――――――――――――――――――――――――――――――― #
-  s.ios.deployment_target = '9.0'
-  s.osx.deployment_target = '10.11'
-  s.tvos.deployment_target = '9.0'
+  s.ios.deployment_target = '10.0'
+  s.osx.deployment_target = '10.12'
+  s.tvos.deployment_target = '10.0'
 
   # ――― Source Location ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――― #
   s.source       = { :git => "https://github.com/phimage/CallbackURLKit.git", :tag => s.version }

CallbackURLKit.xcodeproj/project.pbxproj

@@ -368,7 +368,6 @@
 				INFOPLIST_FILE = Xcode/macOS/Info.plist;
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @loader_path/Frameworks";
-				MACOSX_DEPLOYMENT_TARGET = 10.11;
 				PRODUCT_BUNDLE_IDENTIFIER = fr.phimage.CallbackURLKitOSX;
 				PRODUCT_NAME = CallbackURLKit;
 				SDKROOT = macosx;
@@ -390,7 +389,6 @@
 				INFOPLIST_FILE = Xcode/macOS/Info.plist;
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/../Frameworks @loader_path/Frameworks";
-				MACOSX_DEPLOYMENT_TARGET = 10.11;
 				PRODUCT_BUNDLE_IDENTIFIER = fr.phimage.CallbackURLKitOSX;
 				PRODUCT_NAME = CallbackURLKit;
 				SDKROOT = macosx;
@@ -447,8 +445,8 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 10.0;
-				MACOSX_DEPLOYMENT_TARGET = 10.10;
+				IPHONEOS_DEPLOYMENT_TARGET = 12.2;
+				MACOSX_DEPLOYMENT_TARGET = 10.14;
 				MTL_ENABLE_DEBUG_INFO = YES;
 				ONLY_ACTIVE_ARCH = YES;
 				SDKROOT = iphoneos;
@@ -502,8 +500,8 @@
 				GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
 				GCC_WARN_UNUSED_FUNCTION = YES;
 				GCC_WARN_UNUSED_VARIABLE = YES;
-				IPHONEOS_DEPLOYMENT_TARGET = 10.0;
-				MACOSX_DEPLOYMENT_TARGET = 10.10;
+				IPHONEOS_DEPLOYMENT_TARGET = 12.2;
+				MACOSX_DEPLOYMENT_TARGET = 10.14;
 				MTL_ENABLE_DEBUG_INFO = NO;
 				SDKROOT = iphoneos;
 				SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";

Sources/Manager.swift

@@ -252,22 +252,22 @@ open class Manager {
 
     open func open(url: Foundation.URL) {
         #if APP_EXTENSIONS
-            if let extensionContext = extensionContext {
-                extensionContext.open(url, completionHandler: extensionContextCompletionHandler)
-            }
-            else {
-                #if os(iOS) || os(tvOS)
-                    UIApplication.shared.openURL(url)
-                #elseif os(OSX)
-                    NSWorkspace.shared.open(url)
-                #endif
-            }
-        #else
+        if let extensionContext = extensionContext {
+            extensionContext.open(url, completionHandler: extensionContextCompletionHandler)
+        }
+        else {
             #if os(iOS) || os(tvOS)
-                UIApplication.shared.openURL(url)
+            UIApplication.shared.open(url)
             #elseif os(OSX)
-                NSWorkspace.shared.open(url)
+            NSWorkspace.shared.open(url)
             #endif
+        }
+        #else
+        #if os(iOS) || os(tvOS)
+        UIApplication.shared.open(url)
+        #elseif os(OSX)
+        NSWorkspace.shared.open(url)
+        #endif
         #endif
     }