Skip to content

Commit 9c24f43

Browse files
committed
v1.3.10 - Hides the soft target interact icon (and name)
1 parent 99ac75e commit 9c24f43

File tree

8 files changed

+113
-85
lines changed

8 files changed

+113
-85
lines changed

.github/workflows/package-addon.yml

Lines changed: 0 additions & 61 deletions
This file was deleted.
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
name: Package and release
2+
3+
# run workflow on tags starting with v
4+
on:
5+
push:
6+
tags:
7+
- 'v*'
8+
9+
jobs:
10+
# create and release on CurseForge and wowinterface
11+
# see https://github.com/BigWigsMods/packager
12+
release:
13+
name: Upload to CurseForge and wowinterface
14+
runs-on: ubuntu-latest
15+
16+
env:
17+
CF_API_KEY: ${{ secrets.CURSEFORGE_API_TOKEN }}
18+
WOWI_API_TOKEN: ${{ secrets.WOWI_API_TOKEN }}
19+
GITHUB_OAUTH: ${{ secrets.GITHUB_TOKEN }}
20+
21+
steps:
22+
# we first have to clone the AddOn project, this is a required step
23+
- name: Clone project
24+
uses: actions/checkout@v3
25+
with:
26+
fetch-depth: 0
27+
28+
# get the changes between the last two versions from the manual changelog
29+
- name: Generate changelog
30+
run: |
31+
touch .changes
32+
sed -n '/^##/{p; :loop n; /^##/q; p; b loop}' ./CHANGELOG.md >> .changes
33+
34+
# once cloned, we just run the GitHub Action for the packager project
35+
- name: Package and release
36+
uses: BigWigsMods/packager@v2

.pkgmeta

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
ignore:
2+
- "*.md"
3+
4+
manual-changelog:
5+
filename: .changes
6+
markup-type: markdown

CHANGELOG.md

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
## v1.3.10
2+
- Hides the soft target interact icon (and name)
3+
4+
## v1.3.9
5+
- Update for Dragonflight (10.0.2)
6+
7+
## v1.3.8
8+
- Update for Chains of Domination (9.1.0) (new interface number)
9+
10+
## v1.3.7
11+
- Update for Shadowlands (9.0.5) (new interface number)
12+
13+
## v1.3.6
14+
- Setting to toggle ray traced shadows
15+
16+
## v1.3.5
17+
- Update for Shadowlands pre-expansion patch (9.0.1) (new interface number)
18+
19+
## v1.3.4
20+
- Update for BfA Visions of N'Zoth (8.3) (new interface number)
21+
22+
## v1.3.3
23+
- Update for BfA Rise of Azshara (8.2) (new interface number)
24+
25+
## v1.3.2
26+
- Settings for 'anti aliasing' and 'supersampling' are disabled when 'graphics settings' are not set
27+
28+
## v1.3.1
29+
- Includes CVar `graphicsTextureResolution`
30+
31+
## v1.3
32+
- Option to enhance graphics settings on UI hide
33+
34+
## v1.2
35+
- Includes options to change what to toggle on UI hide (stored via WoW's saved variables)
36+
37+
## v1.1.2
38+
- Update Interface number for BfA Tides of Vengeance (8.1)
39+
40+
## v1.1.1
41+
- Update for BfA prepatch
42+
43+
## v1.1
44+
- Only sets CVars out of combat
45+
46+
## v1.0
47+
- Initial upload

README.md

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,7 @@ This addon does its work automatically when the UIParent frame is hidden. When t
1616
- **phisHideUI_Defaults.lua** contains tables with default values
1717
- **phisHideUI_Utils.lua** contains miscellaneous auxiliary functions
1818

19-
## Changes
20-
- **1.3.9**: Update for Dragonflight (10.0.2)
21-
- **1.3.8**: Update for Chains of Domination (9.1.0) (new interface number)
22-
- **1.3.7**: Update for Shadowlands (9.0.5) (new interface number)
23-
- **1.3.6**: Setting to toggle ray traced shadows
24-
- **1.3.5**: Update for Shadowlands pre-expansion patch (9.0.1) (new interface number)
25-
- **1.3.4**: Update for BfA Visions of N'Zoth (8.3) (new interface number)
26-
- **1.3.3**: Update for BfA Rise of Azshara (8.2) (new interface number)
27-
- **1.3.2**: Settings for 'anti aliasing' and 'supersampling' are disabled when 'graphics settings' are not set
28-
- **1.3.1**: Includes CVar `graphicsTextureResolution`
29-
- **1.3**: Option to enhance graphics settings on UI hide
30-
- **1.2**: Includes options to change what to toggle on UI hide (stored via WoW's saved variables)
31-
- **1.1.2**: Update Interface number for BfA Tides of Vengeance (8.1)
32-
- **1.1.1**: Update for BfA prepatch
33-
- **1.1**: Only sets CVars out of combat
34-
- **1.0**: Initial upload
35-
3619
## To-Do
37-
- [x] Check if all names are hidden
3820
- [ ] Check if only specific CVars are not settable in combat (so no combat check is needed)
39-
- [x] Automatically change graphics settings
40-
- [x] Options page in Blizzard addons settings (hide/show names, pet tracking, chat bubbles, graphics settings (potentially))
41-
- [x] Save temporary variables in saved variable (to prevent losing settings on logging out in between hiding/showing UI)
4221
- [ ] *(Maybe)* Check on login whether the CVar values correspond to the backup and nag the user about restoring or overwriting them
4322
- [ ] *(Maybe)* Implement `okay` and `cancel` functions in the options panel instead of setting the variables on click

phisHideUI.lua

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ local addonName, phis = ...
88
local names_to_toggle = {}
99
local graphics_settings = {}
1010
local pettracking = false
11+
local softtargetinteract = '0'
1112
local names_not_restored = false
1213
local graphics_quality_flag = false
1314

@@ -32,6 +33,7 @@ local function backup_cvars()
3233
for k,v in pairs({'chatBubbles','chatBubblesParty'}) do
3334
settings[v] = GetCVar(v)
3435
end
36+
settings['SoftTargetInteract'] = GetCVar('SoftTargetInteract')
3537
return settings
3638
end
3739

@@ -151,6 +153,16 @@ local function toggle_names_off()
151153
end
152154
end
153155

156+
--- INTERACT ICON / NAME ---
157+
if phisHideUISavedVars.softtargetinteract then
158+
-- GetCVar returns a string and not a number
159+
local sti = GetCVar('SoftTargetInteract')
160+
if sti ~= nil and sti ~= '0' then
161+
softtargetinteract = sti
162+
SetCVar('SoftTargetInteract',0)
163+
end
164+
end
165+
154166
--- GRAPHICS SETTINGS --
155167
if phisHideUISavedVars.graphics_settings then
156168
toggle_graphics(true)
@@ -183,6 +195,11 @@ local function toggle_names_on()
183195
end
184196
end
185197

198+
--- INTERACT ICON / NAME ---
199+
if phisHideUISavedVars.softtargetinteract then
200+
SetCVar('SoftTargetInteract',softtargetinteract)
201+
end
202+
186203
--- GRAPHICS SETTINGS --
187204
if phisHideUISavedVars.graphics_settings then
188205
toggle_graphics(false)
@@ -267,7 +284,8 @@ options:SetScript('OnShow', function()
267284
checkboxes.unitnames = create_checkbox('unitnames', options, description_string, 'Unit names')
268285
checkboxes.chatbubbles = create_checkbox('chatbubbles', options, checkboxes.unitnames, 'Chat bubbles')
269286
checkboxes.pettracking_icons = create_checkbox('pettracking_icons', options, checkboxes.chatbubbles, 'Battle pet tracking icons')
270-
checkboxes.graphics_settings = create_checkbox('graphics_settings', options, checkboxes.pettracking_icons, 'High quality graphics settings')
287+
checkboxes.softtargetinteract = create_checkbox('softtargetinteract', options, checkboxes.pettracking_icons, 'Soft target interact icon (and unit name)')
288+
checkboxes.graphics_settings = create_checkbox('graphics_settings', options, checkboxes.softtargetinteract, 'High quality graphics settings')
271289
checkboxes.anti_aliasing = create_checkbox('anti_aliasing', options, checkboxes.graphics_settings, 'Anti aliasing (MSAA + CMAA)')
272290
checkboxes.supersampling = create_checkbox('supersampling', options, checkboxes.anti_aliasing, 'Supersampling (2x)')
273291
checkboxes.raytracing = create_checkbox('raytracing', options, checkboxes.supersampling, 'Ray traced shadows')

phisHideUI.toc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1-
## Interface: 90100
1+
## Interface: 100002
22
## Title: phisHideUI
3+
## Version: 1.3.10
34
## Notes: The addon hides all currently displayed unit names, chat bubbles and pet tracking icons when hiding the UI (e.g. with '|cFF40C7EBAlt-Z|r').
45
## Author: phistoh
6+
## X-Curse-Project-ID: 287565
7+
## X-WoWI-ID: 24563
58
## SavedVariables: phisHideUISavedVars
6-
## Version: 1.3.9
79

810
phisHideUI_Utils.lua
911
phisHideUI_Defaults.lua

phisHideUI_Defaults.lua

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ phis.defaults = {
1111
chatbubbles = true,
1212
pettracking_icons = true,
1313
unitnames = true,
14+
softtargetinteract = true,
1415
graphics_settings = false,
1516
supersampling = false,
1617
anti_aliasing = false,

0 commit comments

Comments
 (0)