Merge pull request #37 from phmatray/codex/find-and-fix-a-critical-bug

Fix required validator to handle boolean values correctly

Author: phmatray

FormCraft.UnitTests/Validators/RequiredValidatorTests.cs

@@ -5,13 +5,17 @@ public class RequiredValidatorTests
     private readonly RequiredValidator<TestModel, string> _stringValidator;
     private readonly RequiredValidator<TestModel, int> _intValidator;
     private readonly RequiredValidator<TestModel, int?> _nullableIntValidator;
+    private readonly RequiredValidator<TestModel, bool> _boolValidator;
+    private readonly RequiredValidator<TestModel, bool?> _nullableBoolValidator;
     private readonly IServiceProvider _services;
 
     public RequiredValidatorTests()
     {
         _stringValidator = new RequiredValidator<TestModel, string>("Field is required");
         _intValidator = new RequiredValidator<TestModel, int>("Field is required");
         _nullableIntValidator = new RequiredValidator<TestModel, int?>("Field is required");
+        _boolValidator = new RequiredValidator<TestModel, bool>("Field is required");
+        _nullableBoolValidator = new RequiredValidator<TestModel, bool?>("Field is required");
         _services = A.Fake<IServiceProvider>();
     }
 
@@ -99,6 +103,76 @@ public async Task ValidateAsync_Int_Should_Pass_When_NonZero()
         result.ErrorMessage.ShouldBeNull();
     }
 
+    [Fact]
+    public async Task ValidateAsync_Bool_Should_Fail_When_False()
+    {
+        // Arrange
+        var model = new TestModel();
+
+        // Act
+        var result = await _boolValidator.ValidateAsync(model, false, _services);
+
+        // Assert
+        result.IsValid.ShouldBeFalse();
+        result.ErrorMessage.ShouldBe("Field is required");
+    }
+
+    [Fact]
+    public async Task ValidateAsync_Bool_Should_Pass_When_True()
+    {
+        // Arrange
+        var model = new TestModel();
+
+        // Act
+        var result = await _boolValidator.ValidateAsync(model, true, _services);
+
+        // Assert
+        result.IsValid.ShouldBeTrue();
+        result.ErrorMessage.ShouldBeNull();
+    }
+
+    [Fact]
+    public async Task ValidateAsync_NullableBool_Should_Fail_When_Null()
+    {
+        // Arrange
+        var model = new TestModel();
+
+        // Act
+        var result = await _nullableBoolValidator.ValidateAsync(model, null, _services);
+
+        // Assert
+        result.IsValid.ShouldBeFalse();
+        result.ErrorMessage.ShouldBe("Field is required");
+    }
+
+    [Fact]
+    public async Task ValidateAsync_NullableBool_Should_Fail_When_False()
+    {
+        // Arrange
+        var model = new TestModel();
+
+        // Act
+        var result = await _nullableBoolValidator.ValidateAsync(model, false, _services);
+
+        // Assert
+        result.IsValid.ShouldBeFalse();
+        result.ErrorMessage.ShouldBe("Field is required");
+    }
+
+    [Fact]
+    public async Task ValidateAsync_NullableBool_Should_Pass_When_True()
+    {
+        // Arrange
+        var model = new TestModel();
+
+        // Act
+        var result = await _nullableBoolValidator.ValidateAsync(model, true, _services);
+
+        // Assert
+        result.IsValid.ShouldBeTrue();
+        result.ErrorMessage.ShouldBeNull();
+    }
+
     [Fact]
     public async Task ValidateAsync_NullableInt_Should_Fail_When_Null()
     {

FormCraft/Forms/Validators/RequiredValidator.cs

@@ -44,6 +44,7 @@ public Task<ValidationResult> ValidateAsync(TModel model, TValue value, IService
         {
             null => false,
             string str => !string.IsNullOrWhiteSpace(str),
+            bool b => b,
             System.Collections.IEnumerable enumerable => enumerable.Cast<object>().Any(),
             _ => true
         };