Skip to content
This repository was archived by the owner on Jul 15, 2025. It is now read-only.

Commit 412cff6

Browse files
committed
post rebase fixup still some tests unhappy
1 parent c8b48b7 commit 412cff6

File tree

3 files changed

+3
-16
lines changed

3 files changed

+3
-16
lines changed

src/main/java/org/biscuitsec/biscuit/token/ThirdPartyBlockRequest.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,7 @@ public Either<Error.FormatError, ThirdPartyBlockContents> createBlock(KeyPair ke
4545

4646
byte[] serializedBlock = res.get();
4747

48-
Signature sgr = KeyPair.generateSignature(keyPair.public_key().algorithm);
49-
sgr.initSign(keyPair.private_key());
50-
sgr.update(serializedBlock);
51-
52-
ByteBuffer algo_buf = ByteBuffer.allocate(4).order(ByteOrder.LITTLE_ENDIAN);
53-
algo_buf.putInt(Integer.valueOf(Schema.PublicKey.Algorithm.Ed25519.getNumber()));
54-
algo_buf.flip();
55-
sgr.update(algo_buf);
56-
sgr.update(previousKey.toBytes());
57-
byte[] signature = sgr.sign();
48+
byte[] signature = keyPair.sign(serializedBlock, previousKey.toBytes());
5849

5950
PublicKey publicKey = keyPair.public_key();
6051

src/main/java/org/biscuitsec/biscuit/token/UnverifiedBiscuit.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,14 +256,14 @@ public ThirdPartyBlockRequest thirdPartyRequest() {
256256
*/
257257
public UnverifiedBiscuit appendThirdPartyBlock(PublicKey externalKey, ThirdPartyBlockContents blockResponse)
258258
throws NoSuchAlgorithmException, SignatureException, InvalidKeyException, Error {
259-
KeyPair nextKeyPair = KeyPair.generate(Schema.PublicKey.Algorithm.Ed25519);
259+
KeyPair nextKeyPair = KeyPair.generate(externalKey.algorithm);
260260

261261
Signature sgr = KeyPair.generateSignature(externalKey.algorithm);
262262
sgr.initVerify(externalKey.key);
263263

264264
sgr.update(blockResponse.payload);
265265
ByteBuffer algo_buf = ByteBuffer.allocate(4).order(ByteOrder.LITTLE_ENDIAN);
266-
algo_buf.putInt(Integer.valueOf(Schema.PublicKey.Algorithm.Ed25519.getNumber()));
266+
algo_buf.putInt(Integer.valueOf(externalKey.algorithm.getNumber()));
267267
algo_buf.flip();
268268
sgr.update(algo_buf);
269269

src/main/java/org/biscuitsec/biscuit/token/builder/Biscuit.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,8 @@
22

33
import org.biscuitsec.biscuit.crypto.KeyPair;
44
import org.biscuitsec.biscuit.crypto.PublicKey;
5-
import org.biscuitsec.biscuit.crypto.Signer;
65
import org.biscuitsec.biscuit.datalog.SchemaVersion;
76
import org.biscuitsec.biscuit.datalog.SymbolTable;
8-
import org.biscuitsec.biscuit.datalog.Check;
9-
import org.biscuitsec.biscuit.datalog.Fact;
10-
import org.biscuitsec.biscuit.datalog.Rule;
117
import org.biscuitsec.biscuit.error.Error;
128
import org.biscuitsec.biscuit.token.Block;
139
import io.vavr.Tuple2;

0 commit comments

Comments
 (0)