Skip to content

Commit 45973e0

Browse files
committed
Change wording from ip to address
We'll support connecting to hostnames soon too
1 parent 8a92211 commit 45973e0

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

lib/dns_cluster.ex

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,20 +97,20 @@ defmodule DNSCluster do
9797
resolver: resolver
9898
}
9999

100-
{:ok, state, {:continue, :discover_ips}}
100+
{:ok, state, {:continue, :discover_addresses}}
101101

102102
:error ->
103103
raise ArgumentError, "missing required :query option in #{inspect(opts)}"
104104
end
105105
end
106106

107107
@impl true
108-
def handle_continue(:discover_ips, state) do
108+
def handle_continue(:discover_addresses, state) do
109109
{:noreply, do_discovery(state)}
110110
end
111111

112112
@impl true
113-
def handle_info(:discover_ips, state) do
113+
def handle_info(:discover_addresses, state) do
114114
{:noreply, do_discovery(state)}
115115
end
116116

@@ -123,19 +123,19 @@ defmodule DNSCluster do
123123
defp connect_new_nodes(%{resolver: resolver, connect_timeout: timeout} = state) do
124124
node_names = for name <- resolver.list_nodes(), into: MapSet.new(), do: to_string(name)
125125

126-
ips = discover_ips(state)
126+
addresses = discover_addresses(state)
127127

128128
_results =
129-
ips
130-
|> Enum.map(fn {basename, ip} -> "#{basename}@#{ip}" end)
129+
addresses
130+
|> Enum.map(fn {basename, address} -> "#{basename}@#{address}" end)
131131
|> Enum.filter(fn node_name -> !Enum.member?(node_names, node_name) end)
132132
|> Task.async_stream(
133133
fn new_name ->
134134
if resolver.connect_node(:"#{new_name}") do
135135
log(state, "#{node()} connected to #{new_name}")
136136
end
137137
end,
138-
max_concurrency: max(1, length(ips)),
138+
max_concurrency: max(1, length(addresses)),
139139
timeout: timeout
140140
)
141141
|> Enum.to_list()
@@ -148,10 +148,12 @@ defmodule DNSCluster do
148148
end
149149

150150
defp schedule_next_poll(state) do
151-
%{state | poll_timer: Process.send_after(self(), :discover_ips, state.interval)}
151+
%{state | poll_timer: Process.send_after(self(), :discover_addresses, state.interval)}
152152
end
153153

154-
defp discover_ips(%{resolver: resolver, query: queries, resource_types: resource_types} = state) do
154+
defp discover_addresses(
155+
%{resolver: resolver, query: queries, resource_types: resource_types} = state
156+
) do
155157
for resource_type <- resource_types,
156158
query <- queries,
157159
basename = basename_from_query_or_state(query, state),

0 commit comments

Comments
 (0)