Skip to content

Commit 9156c86

Browse files
authored
Update CoreComponents input, add for attr to label tags (#6586)
1 parent 4bc34f6 commit 9156c86

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

installer/templates/phx_web/components/core_components.ex

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ defmodule <%= @web_namespace %>.CoreComponents do
207207

208208
~H"""
209209
<div class="fieldset mb-2">
210-
<label>
210+
<label for={@id}>
211211
<input
212212
type="hidden"
213213
name={@name}
@@ -235,7 +235,7 @@ defmodule <%= @web_namespace %>.CoreComponents do
235235
def input(%{type: "select"} = assigns) do
236236
~H"""
237237
<div class="fieldset mb-2">
238-
<label>
238+
<label for={@id}>
239239
<span :if={@label} class="label mb-1">{@label}</span>
240240
<select
241241
id={@id}
@@ -256,7 +256,7 @@ defmodule <%= @web_namespace %>.CoreComponents do
256256
def input(%{type: "textarea"} = assigns) do
257257
~H"""
258258
<div class="fieldset mb-2">
259-
<label>
259+
<label for={@id}>
260260
<span :if={@label} class="label mb-1">{@label}</span>
261261
<textarea
262262
id={@id}
@@ -277,7 +277,7 @@ defmodule <%= @web_namespace %>.CoreComponents do
277277
def input(assigns) do
278278
~H"""
279279
<div class="fieldset mb-2">
280-
<label>
280+
<label for={@id}>
281281
<span :if={@label} class="label mb-1">{@label}</span>
282282
<input
283283
type={@type}

0 commit comments

Comments
 (0)