Skip to content

Commit c9b431f

Browse files
authored
Add pool_count as an example for performance (#6014)
1 parent 0ad88cd commit c9b431f

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

installer/lib/phx_new/generator.ex

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,8 @@ defmodule Phx.New.Generator do
188188
{adapter_app, adapter_module, adapter_config} =
189189
get_ecto_adapter(db, String.downcase(project.app), project.app_mod)
190190

191-
{web_adapter_app, web_adapter_vsn, web_adapter_module, web_adapter_docs} = get_web_adapter(web_adapter)
191+
{web_adapter_app, web_adapter_vsn, web_adapter_module, web_adapter_docs} =
192+
get_web_adapter(web_adapter)
192193

193194
pubsub_server = get_pubsub_server(project.app_mod)
194195

@@ -304,8 +305,16 @@ defmodule Phx.New.Generator do
304305
Mix.raise("Unknown database #{inspect(db)}")
305306
end
306307

307-
defp get_web_adapter("cowboy"), do: {:plug_cowboy, "~> 2.7", Phoenix.Endpoint.Cowboy2Adapter, "https://hexdocs.pm/plug_cowboy/Plug.Cowboy.html"}
308-
defp get_web_adapter("bandit"), do: {:bandit, "~> 1.5", Bandit.PhoenixAdapter, "https://hexdocs.pm/bandit/Bandit.html#t:options/0"}
308+
defp get_web_adapter("cowboy"),
309+
do:
310+
{:plug_cowboy, "~> 2.7", Phoenix.Endpoint.Cowboy2Adapter,
311+
"https://hexdocs.pm/plug_cowboy/Plug.Cowboy.html"}
312+
313+
defp get_web_adapter("bandit"),
314+
do:
315+
{:bandit, "~> 1.5", Bandit.PhoenixAdapter,
316+
"https://hexdocs.pm/bandit/Bandit.html#t:options/0"}
317+
309318
defp get_web_adapter(other), do: Mix.raise("Unknown web adapter #{inspect(other)}")
310319

311320
defp fs_db_config(app, module) do
@@ -380,6 +389,8 @@ defmodule Phx.New.Generator do
380389
# ssl: true,
381390
url: database_url,
382391
pool_size: String.to_integer(System.get_env("POOL_SIZE") || "10"),
392+
# For machines with several cores, consider starting multiple pools of `pool_size`
393+
# pool_count: 4,
383394
socket_options: maybe_ipv6
384395
"""
385396
]

0 commit comments

Comments
 (0)